Skip to content

Check for valid modifier combinations #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
stschott opened this issue Jan 4, 2024 · 2 comments · May be fixed by #1277
Open

Check for valid modifier combinations #794

stschott opened this issue Jan 4, 2024 · 2 comments · May be fixed by #1277
Assignees
@sahilagichani14

Comments

@stschott
Copy link
Collaborator

stschott commented Jan 4, 2024

FieldModifier.toString(...) already assumes valid Modifier combinations (theoretically its currently possible to assign public+private+protected modifier at the same time) - maybe we should implement a wrapper of EnumSet<...Modifier> to handle only valid combinations and implement toString there?

Originally posted by @swissiety in #793 (comment)
@swissiety swissiety changed the title Check for valid modifier combinations before printing Check for valid modifier combinations Jan 5, 2024
@sahilagichani14 sahilagichani14 linked a pull request Apr 18, 2025 that will close this issue
794 check for valid modifier combinations #1277
Draft
@sahilagichani14
Copy link
Collaborator

linked to #322

@sahilagichani14
Copy link
Collaborator

Missing in SootUp:
StackTypesValidator -> need VMStateAnalysis for Baf, so not needed?
UsesValidator -> returns null in SootUp, need PedanticThrowAnalysis? Is there in SootUp?
CheckTypesValidator -> returns null in SootUp
InvokeArgumentValidator -> returns null in SootUp
StmtsValidator -> returns null in SootUp
CheckVoidLocalesValidator
CheckEscapingValidator
UnitBoxesValidator
ValueBoxesValidator
IdentityValidator
ReturnStatementsValidator
InvokeValidator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sahilagichani14 sahilagichani14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

794 check for valid modifier combinations soot-oss/SootUp
2 participants
@stschott @sahilagichani14