Skip to content

Commit 4c3a0f0

Browse files
committed
Support parallel initialization of Testcontainers
Add support for a `spring.testcontainers.startup` property that can be set to "sequential" or "parallel" to change how containers are started. Closes gh-37073
1 parent 1edd1d5 commit 4c3a0f0

File tree

11 files changed

+293
-16
lines changed

11 files changed

+293
-16
lines changed

buildSrc/src/main/java/org/springframework/boot/build/context/properties/DocumentConfigurationProperties.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,10 @@ void documentConfigurationProperties() throws IOException {
7878
snippets.add("application-properties.security", "Security Properties", this::securityPrefixes);
7979
snippets.add("application-properties.rsocket", "RSocket Properties", this::rsocketPrefixes);
8080
snippets.add("application-properties.actuator", "Actuator Properties", this::actuatorPrefixes);
81-
snippets.add("application-properties.docker-compose", "Docker Compose Properties", this::dockerComposePrefixes);
8281
snippets.add("application-properties.devtools", "Devtools Properties", this::devtoolsPrefixes);
82+
snippets.add("application-properties.docker-compose", "Docker Compose Properties", this::dockerComposePrefixes);
83+
snippets.add("application-properties.testcontainers", "Testcontainers Properties",
84+
this::testcontainersPrefixes);
8385
snippets.add("application-properties.testing", "Testing Properties", this::testingPrefixes);
8486
snippets.writeTo(this.outputDir.toPath());
8587
}
@@ -224,7 +226,11 @@ private void devtoolsPrefixes(Config prefix) {
224226
}
225227

226228
private void testingPrefixes(Config prefix) {
227-
prefix.accept("spring.test");
229+
prefix.accept("spring.test.");
230+
}
231+
232+
private void testcontainersPrefixes(Config prefix) {
233+
prefix.accept("spring.testcontainers.");
228234
}
229235

230236
}

spring-boot-project/spring-boot-docs/build.gradle

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ dependencies {
6161
asciidoctorExtensions(project(path: ":spring-boot-project:spring-boot-autoconfigure"))
6262
asciidoctorExtensions(project(path: ":spring-boot-project:spring-boot-devtools"))
6363
asciidoctorExtensions(project(path: ":spring-boot-project:spring-boot-docker-compose"))
64+
asciidoctorExtensions(project(path: ":spring-boot-project:spring-boot-testcontainers"))
6465

6566
autoConfiguration(project(path: ":spring-boot-project:spring-boot-autoconfigure", configuration: "autoConfigurationMetadata"))
6667
autoConfiguration(project(path: ":spring-boot-project:spring-boot-actuator-autoconfigure", configuration: "autoConfigurationMetadata"))
@@ -74,6 +75,7 @@ dependencies {
7475
configurationProperties(project(path: ":spring-boot-project:spring-boot-docker-compose", configuration: "configurationPropertiesMetadata"))
7576
configurationProperties(project(path: ":spring-boot-project:spring-boot-devtools", configuration: "configurationPropertiesMetadata"))
7677
configurationProperties(project(path: ":spring-boot-project:spring-boot-test-autoconfigure", configuration: "configurationPropertiesMetadata"))
78+
configurationProperties(project(path: ":spring-boot-project:spring-boot-testcontainers", configuration: "configurationPropertiesMetadata"))
7779

7880
gradlePluginDocumentation(project(path: ":spring-boot-project:spring-boot-tools:spring-boot-gradle-plugin", configuration: "documentation"))
7981

spring-boot-project/spring-boot-docs/src/docs/asciidoc/application-properties.adoc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,4 +47,6 @@ include::application-properties/devtools.adoc[]
4747

4848
include::application-properties/docker-compose.adoc[]
4949

50+
include::application-properties/testcontainers.adoc[]
51+
5052
include::application-properties/testing.adoc[]

spring-boot-project/spring-boot-docs/src/docs/asciidoc/features/testing.adoc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1072,6 +1072,9 @@ include::code:test/MyContainersConfiguration[]
10721072
NOTE: The lifecycle of `Container` beans is automatically managed by Spring Boot.
10731073
Containers will be started and stopped automatically.
10741074

1075+
TIP: You can use the configprop:spring.testcontainers.startup[] property to change how containers are started.
1076+
By default `sequential` startup is used, but you may also choose `parallel` if you wish to start multiple containers in parallel.
1077+
10751078
Once you have defined your test configuration, you can use the `with(...)` method to attach it to your test launcher:
10761079

10771080
include::code:test/TestMyApplication[]

spring-boot-project/spring-boot-testcontainers/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
plugins {
22
id "java-library"
33
id "org.springframework.boot.auto-configuration"
4+
id "org.springframework.boot.configuration-properties"
45
id "org.springframework.boot.conventions"
56
id "org.springframework.boot.deployed"
67
id "org.springframework.boot.optional-dependencies"

spring-boot-project/spring-boot-testcontainers/src/main/java/org/springframework/boot/testcontainers/lifecycle/TestcontainersLifecycleApplicationContextInitializer.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ public void initialize(ConfigurableApplicationContext applicationContext) {
4747
}
4848
ConfigurableListableBeanFactory beanFactory = applicationContext.getBeanFactory();
4949
applicationContext.addBeanFactoryPostProcessor(new TestcontainersLifecycleBeanFactoryPostProcessor());
50-
beanFactory.addBeanPostProcessor(new TestcontainersLifecycleBeanPostProcessor(beanFactory));
50+
TestcontainersStartup startup = TestcontainersStartup.get(applicationContext.getEnvironment());
51+
beanFactory.addBeanPostProcessor(new TestcontainersLifecycleBeanPostProcessor(beanFactory, startup));
5152
}
5253

5354
}

spring-boot-project/spring-boot-testcontainers/src/main/java/org/springframework/boot/testcontainers/lifecycle/TestcontainersLifecycleBeanPostProcessor.java

Lines changed: 28 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,11 @@
1616

1717
package org.springframework.boot.testcontainers.lifecycle;
1818

19+
import java.util.ArrayList;
1920
import java.util.LinkedHashSet;
2021
import java.util.List;
2122
import java.util.Set;
23+
import java.util.stream.Collectors;
2224

2325
import org.apache.commons.logging.Log;
2426
import org.apache.commons.logging.LogFactory;
@@ -58,48 +60,61 @@ class TestcontainersLifecycleBeanPostProcessor implements DestructionAwareBeanPo
5860

5961
private final ConfigurableListableBeanFactory beanFactory;
6062

63+
private final TestcontainersStartup startup;
64+
6165
private volatile boolean containersInitialized = false;
6266

63-
TestcontainersLifecycleBeanPostProcessor(ConfigurableListableBeanFactory beanFactory) {
67+
TestcontainersLifecycleBeanPostProcessor(ConfigurableListableBeanFactory beanFactory,
68+
TestcontainersStartup startup) {
6469
this.beanFactory = beanFactory;
70+
this.startup = startup;
6571
}
6672

6773
@Override
6874
public Object postProcessAfterInitialization(Object bean, String beanName) throws BeansException {
69-
if (bean instanceof Startable startable) {
70-
startable.start();
71-
}
72-
if (this.beanFactory.isConfigurationFrozen()) {
75+
if (!this.containersInitialized && this.beanFactory.isConfigurationFrozen()) {
7376
initializeContainers();
7477
}
7578
return bean;
7679
}
7780

7881
private void initializeContainers() {
79-
if (this.containersInitialized) {
80-
return;
81-
}
82-
this.containersInitialized = true;
8382
Set<String> beanNames = new LinkedHashSet<>();
8483
beanNames.addAll(List.of(this.beanFactory.getBeanNamesForType(ContainerState.class, false, false)));
8584
beanNames.addAll(List.of(this.beanFactory.getBeanNamesForType(Startable.class, false, false)));
85+
initializeContainers(beanNames);
86+
}
87+
88+
private void initializeContainers(Set<String> beanNames) {
89+
List<Object> beans = new ArrayList<>(beanNames.size());
8690
for (String beanName : beanNames) {
8791
try {
88-
this.beanFactory.getBean(beanName);
92+
beans.add(this.beanFactory.getBean(beanName));
8993
}
9094
catch (BeanCreationException ex) {
9195
if (ex.contains(BeanCurrentlyInCreationException.class)) {
92-
this.containersInitialized = false;
9396
return;
9497
}
9598
throw ex;
9699
}
97100
}
98-
if (!beanNames.isEmpty()) {
99-
logger.debug(LogMessage.format("Initialized container beans '%s'", beanNames));
101+
if (!this.containersInitialized) {
102+
this.containersInitialized = true;
103+
if (!beanNames.isEmpty()) {
104+
logger.debug(LogMessage.format("Initialized container beans '%s'", beanNames));
105+
}
106+
start(beans);
100107
}
101108
}
102109

110+
private void start(List<Object> beans) {
111+
Set<Startable> startables = beans.stream()
112+
.filter(Startable.class::isInstance)
113+
.map(Startable.class::cast)
114+
.collect(Collectors.toCollection(LinkedHashSet::new));
115+
this.startup.start(startables);
116+
}
117+
103118
@Override
104119
public boolean requiresDestruction(Object bean) {
105120
return bean instanceof Startable;
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,94 @@
1+
/*
2+
* Copyright 2012-2023 the original author or authors.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* https://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
17+
package org.springframework.boot.testcontainers.lifecycle;
18+
19+
import java.util.Collection;
20+
21+
import org.testcontainers.lifecycle.Startable;
22+
import org.testcontainers.lifecycle.Startables;
23+
24+
import org.springframework.core.env.ConfigurableEnvironment;
25+
import org.springframework.core.env.Environment;
26+
27+
/**
28+
* Testcontainers startup strategies. The strategy to use can be configured in the Spring
29+
* {@link Environment} with a {@value #PROPERTY} property.
30+
*
31+
* @author Phillip Webb
32+
* @since 3.2.0
33+
*/
34+
public enum TestcontainersStartup {
35+
36+
/**
37+
* Startup containers sequentially.
38+
*/
39+
SEQUENTIAL {
40+
41+
@Override
42+
void start(Collection<? extends Startable> startables) {
43+
startables.forEach(Startable::start);
44+
}
45+
46+
},
47+
48+
/**
49+
* Startup containers in parallel.
50+
*/
51+
PARALLEL {
52+
53+
@Override
54+
void start(Collection<? extends Startable> startables) {
55+
Startables.deepStart(startables).join();
56+
}
57+
58+
};
59+
60+
/**
61+
* The {@link Environment} property used to change the {@link TestcontainersStartup}
62+
* strategy.
63+
*/
64+
public static final String PROPERTY = "spring.testcontainers.startup";
65+
66+
abstract void start(Collection<? extends Startable> startables);
67+
68+
static TestcontainersStartup get(ConfigurableEnvironment environment) {
69+
return get((environment != null) ? environment.getProperty(PROPERTY) : null);
70+
}
71+
72+
private static TestcontainersStartup get(String value) {
73+
if (value == null) {
74+
return SEQUENTIAL;
75+
}
76+
String canonicalName = getCanonicalName(value);
77+
for (TestcontainersStartup candidate : values()) {
78+
if (candidate.name().equalsIgnoreCase(canonicalName)) {
79+
return candidate;
80+
}
81+
}
82+
throw new IllegalArgumentException("Unknown '%s' property value '%s'".formatted(PROPERTY, value));
83+
}
84+
85+
private static String getCanonicalName(String name) {
86+
StringBuilder canonicalName = new StringBuilder(name.length());
87+
name.chars()
88+
.filter(Character::isLetterOrDigit)
89+
.map(Character::toLowerCase)
90+
.forEach((c) -> canonicalName.append((char) c));
91+
return canonicalName.toString();
92+
}
93+
94+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"properties": [
3+
{
4+
"name": "spring.testcontainers.startup",
5+
"type": "org.springframework.boot.testcontainers.lifecycle.TestcontainersStartup",
6+
"description": "Testcontainers startup modes.",
7+
"defaultValue": "sequential"
8+
}
9+
]
10+
}

spring-boot-project/spring-boot-testcontainers/src/test/java/org/springframework/boot/testcontainers/lifecycle/TestcontainersLifecycleApplicationContextInitializerTests.java

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,18 @@
1616

1717
package org.springframework.boot.testcontainers.lifecycle;
1818

19+
import java.util.Map;
20+
1921
import org.junit.jupiter.api.Test;
2022
import org.testcontainers.containers.GenericContainer;
2123
import org.testcontainers.lifecycle.Startable;
2224

25+
import org.springframework.beans.factory.config.BeanPostProcessor;
26+
import org.springframework.beans.factory.support.AbstractBeanFactory;
2327
import org.springframework.context.annotation.AnnotationConfigApplicationContext;
2428
import org.springframework.context.annotation.Bean;
2529
import org.springframework.context.annotation.Configuration;
30+
import org.springframework.core.env.MapPropertySource;
2631

2732
import static org.assertj.core.api.Assertions.assertThat;
2833
import static org.mockito.BDDMockito.given;
@@ -104,6 +109,22 @@ void dealsWithBeanCurrentlyInCreationException() {
104109
applicationContext.refresh();
105110
}
106111

112+
@Test
113+
void setupStartupBasedOnEnvironmentProperty() {
114+
AnnotationConfigApplicationContext applicationContext = new AnnotationConfigApplicationContext();
115+
applicationContext.getEnvironment()
116+
.getPropertySources()
117+
.addLast(new MapPropertySource("test", Map.of("spring.testcontainers.startup", "parallel")));
118+
new TestcontainersLifecycleApplicationContextInitializer().initialize(applicationContext);
119+
AbstractBeanFactory beanFactory = (AbstractBeanFactory) applicationContext.getBeanFactory();
120+
BeanPostProcessor beanPostProcessor = beanFactory.getBeanPostProcessors()
121+
.stream()
122+
.filter(TestcontainersLifecycleBeanPostProcessor.class::isInstance)
123+
.findFirst()
124+
.get();
125+
assertThat(beanPostProcessor).extracting("startup").isEqualTo(TestcontainersStartup.PARALLEL);
126+
}
127+
107128
private AnnotationConfigApplicationContext createApplicationContext(Startable container) {
108129
AnnotationConfigApplicationContext applicationContext = new AnnotationConfigApplicationContext();
109130
new TestcontainersLifecycleApplicationContextInitializer().initialize(applicationContext);

0 commit comments

Comments
 (0)