From b29ee53344a884b2cb4e49060547f2544b4fdac1 Mon Sep 17 00:00:00 2001 From: Seonghyeon Cho Date: Sun, 18 May 2025 01:25:40 +0900 Subject: [PATCH 1/2] Fix docs on `RetryableTopic.replicationFactor()` Signed-off-by: Seonghyeon Cho --- .../org/springframework/kafka/annotation/RetryableTopic.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spring-kafka/src/main/java/org/springframework/kafka/annotation/RetryableTopic.java b/spring-kafka/src/main/java/org/springframework/kafka/annotation/RetryableTopic.java index af9a6a6051..8f92b8893c 100644 --- a/spring-kafka/src/main/java/org/springframework/kafka/annotation/RetryableTopic.java +++ b/spring-kafka/src/main/java/org/springframework/kafka/annotation/RetryableTopic.java @@ -119,7 +119,7 @@ /** * The replication factor for the automatically created topics. Expressions must * resolve to a short or a String that can be parsed as such. Default is -1 to use the - * broker default if the broker is earlier than version 2.4, an explicit value is + * broker default. If the broker is earlier than version 2.4, an explicit value is * required. * * @return the replication factor. From 49c48d07f415d1899b4edc665d7da37b5c4b5a3a Mon Sep 17 00:00:00 2001 From: Seonghyeon Cho Date: Sun, 18 May 2025 01:28:17 +0900 Subject: [PATCH 2/2] Rephrase replicationFactor description about broker version Signed-off-by: Seonghyeon Cho --- .../kafka/retrytopic/RetryTopicConfigurationBuilder.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/spring-kafka/src/main/java/org/springframework/kafka/retrytopic/RetryTopicConfigurationBuilder.java b/spring-kafka/src/main/java/org/springframework/kafka/retrytopic/RetryTopicConfigurationBuilder.java index 757841ed24..1ba94a8be9 100644 --- a/spring-kafka/src/main/java/org/springframework/kafka/retrytopic/RetryTopicConfigurationBuilder.java +++ b/spring-kafka/src/main/java/org/springframework/kafka/retrytopic/RetryTopicConfigurationBuilder.java @@ -432,8 +432,8 @@ public RetryTopicConfigurationBuilder doNotAutoCreateRetryTopics() { * Configure the topic creation behavior to auto create topics with the provided * properties. * @param numPartitions the number of partitions. - * @param replicationFactor the replication factor (-1 to use the broker default if the - * broker is version 2.4 or later). + * @param replicationFactor the replication factor (-1 to use the broker default. If the + * broker is earlier than version 2.4, an explicit value is required). * @return the builder. */ public RetryTopicConfigurationBuilder autoCreateTopicsWith(@Nullable Integer numPartitions, @Nullable Short replicationFactor) { @@ -447,8 +447,8 @@ public RetryTopicConfigurationBuilder autoCreateTopicsWith(@Nullable Integer num * properties. * @param shouldCreate true to auto create. * @param numPartitions the number of partitions. - * @param replicationFactor the replication factor (-1 to use the broker default if the - * broker is version 2.4 or later). + * @param replicationFactor the replication factor (-1 to use the broker default. If the + * broker is earlier than version 2.4, an explicit value is required). * @return the builder. */ public RetryTopicConfigurationBuilder autoCreateTopics(@Nullable Boolean shouldCreate, @Nullable Integer numPartitions,