Don't Support Serialization for Jackson (De)serializers

jzheaux · jzheaux · commit 8e59fa17194d · 2025-01-14T17:35:33.000-07:00
Issue gh-16276
diff --git a/web/src/main/java/org/springframework/security/web/webauthn/jackson/AttestationConveyancePreferenceSerializer.java b/web/src/main/java/org/springframework/security/web/webauthn/jackson/AttestationConveyancePreferenceSerializer.java
@@ -30,6 +30,7 @@
  * @author Rob Winch
  * @since 6.4
  */
+@SuppressWarnings("serial")
 class AttestationConveyancePreferenceSerializer extends StdSerializer<AttestationConveyancePreference> {
 
 	AttestationConveyancePreferenceSerializer() {
diff --git a/web/src/main/java/org/springframework/security/web/webauthn/jackson/AuthenticationExtensionsClientInputSerializer.java b/web/src/main/java/org/springframework/security/web/webauthn/jackson/AuthenticationExtensionsClientInputSerializer.java
@@ -30,6 +30,7 @@
  * @author Rob Winch
  * @since 6.4
  */
+@SuppressWarnings("serial")
 class AuthenticationExtensionsClientInputSerializer extends StdSerializer<AuthenticationExtensionsClientInput> {
 
 	/**
diff --git a/web/src/main/java/org/springframework/security/web/webauthn/jackson/AuthenticationExtensionsClientInputsSerializer.java b/web/src/main/java/org/springframework/security/web/webauthn/jackson/AuthenticationExtensionsClientInputsSerializer.java
@@ -31,6 +31,7 @@
  * @author Rob Winch
  * @since 6.4
  */
+@SuppressWarnings("serial")
 class AuthenticationExtensionsClientInputsSerializer extends StdSerializer<AuthenticationExtensionsClientInputs> {
 
 	/**
diff --git a/web/src/main/java/org/springframework/security/web/webauthn/jackson/AuthenticationExtensionsClientOutputsDeserializer.java b/web/src/main/java/org/springframework/security/web/webauthn/jackson/AuthenticationExtensionsClientOutputsDeserializer.java
@@ -39,6 +39,7 @@
  * @author Rob Winch
  * @since 6.4
  */
+@SuppressWarnings("serial")
 class AuthenticationExtensionsClientOutputsDeserializer extends StdDeserializer<AuthenticationExtensionsClientOutputs> {
 
 	private static final Log logger = LogFactory.getLog(AuthenticationExtensionsClientOutputsDeserializer.class);
diff --git a/web/src/main/java/org/springframework/security/web/webauthn/jackson/AuthenticatorAttachmentDeserializer.java b/web/src/main/java/org/springframework/security/web/webauthn/jackson/AuthenticatorAttachmentDeserializer.java
@@ -31,6 +31,7 @@
  * @author Rob Winch
  * @since 6.4
  */
+@SuppressWarnings("serial")
 class AuthenticatorAttachmentDeserializer extends StdDeserializer<AuthenticatorAttachment> {
 
 	AuthenticatorAttachmentDeserializer() {
diff --git a/web/src/main/java/org/springframework/security/web/webauthn/jackson/AuthenticatorAttachmentSerializer.java b/web/src/main/java/org/springframework/security/web/webauthn/jackson/AuthenticatorAttachmentSerializer.java
@@ -30,6 +30,7 @@
  * @author Rob Winch
  * @since 6.4
  */
+@SuppressWarnings("serial")
 class AuthenticatorAttachmentSerializer extends StdSerializer<AuthenticatorAttachment> {
 
 	AuthenticatorAttachmentSerializer() {
diff --git a/web/src/main/java/org/springframework/security/web/webauthn/jackson/AuthenticatorTransportDeserializer.java b/web/src/main/java/org/springframework/security/web/webauthn/jackson/AuthenticatorTransportDeserializer.java
@@ -31,6 +31,7 @@
  * @author Rob Winch
  * @since 6.4
  */
+@SuppressWarnings("serial")
 class AuthenticatorTransportDeserializer extends StdDeserializer<AuthenticatorTransport> {
 
 	AuthenticatorTransportDeserializer() {
diff --git a/web/src/main/java/org/springframework/security/web/webauthn/jackson/BytesSerializer.java b/web/src/main/java/org/springframework/security/web/webauthn/jackson/BytesSerializer.java
@@ -30,6 +30,7 @@
  * @author Rob Winch
  * @since 6.4
  */
+@SuppressWarnings("serial")
 class BytesSerializer extends StdSerializer<Bytes> {
 
 	/**
diff --git a/web/src/main/java/org/springframework/security/web/webauthn/jackson/COSEAlgorithmIdentifierDeserializer.java b/web/src/main/java/org/springframework/security/web/webauthn/jackson/COSEAlgorithmIdentifierDeserializer.java
@@ -31,6 +31,7 @@
  * @author Rob Winch
  * @since 6.4
  */
+@SuppressWarnings("serial")
 class COSEAlgorithmIdentifierDeserializer extends StdDeserializer<COSEAlgorithmIdentifier> {
 
 	COSEAlgorithmIdentifierDeserializer() {
diff --git a/web/src/main/java/org/springframework/security/web/webauthn/jackson/COSEAlgorithmIdentifierSerializer.java b/web/src/main/java/org/springframework/security/web/webauthn/jackson/COSEAlgorithmIdentifierSerializer.java
@@ -30,6 +30,7 @@
  * @author Rob Winch
  * @since 6.4
  */
+@SuppressWarnings("serial")
 class COSEAlgorithmIdentifierSerializer extends StdSerializer<COSEAlgorithmIdentifier> {
 
 	COSEAlgorithmIdentifierSerializer() {
diff --git a/web/src/main/java/org/springframework/security/web/webauthn/jackson/CredProtectAuthenticationExtensionsClientInputSerializer.java b/web/src/main/java/org/springframework/security/web/webauthn/jackson/CredProtectAuthenticationExtensionsClientInputSerializer.java
@@ -31,6 +31,7 @@
  *
  * @author Rob Winch
  */
+@SuppressWarnings("serial")
 class CredProtectAuthenticationExtensionsClientInputSerializer
 		extends StdSerializer<CredProtectAuthenticationExtensionsClientInput> {
 
diff --git a/web/src/main/java/org/springframework/security/web/webauthn/jackson/DurationSerializer.java b/web/src/main/java/org/springframework/security/web/webauthn/jackson/DurationSerializer.java
@@ -29,6 +29,7 @@
  * @author Rob Winch
  * @since 6.4
  */
+@SuppressWarnings("serial")
 class DurationSerializer extends StdSerializer<Duration> {
 
 	/**
diff --git a/web/src/main/java/org/springframework/security/web/webauthn/jackson/PublicKeyCredentialTypeDeserializer.java b/web/src/main/java/org/springframework/security/web/webauthn/jackson/PublicKeyCredentialTypeDeserializer.java
@@ -31,6 +31,7 @@
  * @author Rob Winch
  * @since 6.4
  */
+@SuppressWarnings("serial")
 class PublicKeyCredentialTypeDeserializer extends StdDeserializer<PublicKeyCredentialType> {
 
 	/**
diff --git a/web/src/main/java/org/springframework/security/web/webauthn/jackson/PublicKeyCredentialTypeSerializer.java b/web/src/main/java/org/springframework/security/web/webauthn/jackson/PublicKeyCredentialTypeSerializer.java
@@ -30,6 +30,7 @@
  * @author Rob Winch
  * @since 6.4
  */
+@SuppressWarnings("serial")
 class PublicKeyCredentialTypeSerializer extends StdSerializer<PublicKeyCredentialType> {
 
 	/**
diff --git a/web/src/main/java/org/springframework/security/web/webauthn/jackson/ResidentKeyRequirementSerializer.java b/web/src/main/java/org/springframework/security/web/webauthn/jackson/ResidentKeyRequirementSerializer.java
@@ -30,6 +30,7 @@
  * @author Rob Winch
  * @since 6.4
  */
+@SuppressWarnings("serial")
 class ResidentKeyRequirementSerializer extends StdSerializer<ResidentKeyRequirement> {
 
 	/**
diff --git a/web/src/main/java/org/springframework/security/web/webauthn/jackson/UserVerificationRequirementSerializer.java b/web/src/main/java/org/springframework/security/web/webauthn/jackson/UserVerificationRequirementSerializer.java
@@ -30,6 +30,7 @@
  * @author Rob Winch
  * @since 6.4
  */
+@SuppressWarnings("serial")
 class UserVerificationRequirementSerializer extends StdSerializer<UserVerificationRequirement> {
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@`
`31`	`31`	`*`
`32`	`32`	`* @author Rob Winch`
`33`	`33`	`*/`
	`34`	`+@SuppressWarnings("serial")`
`34`	`35`	`class CredProtectAuthenticationExtensionsClientInputSerializer`
`35`	`36`	`extends StdSerializer<CredProtectAuthenticationExtensionsClientInput> {`
`36`	`37`