Skip to content

🔴 Resolve Token Collision Issue #22349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task
shivekkhurana opened this issue Mar 20, 2025 · 2 comments · May be fixed by #22399
Open
1 task

🔴 Resolve Token Collision Issue #22349

shivekkhurana opened this issue Mar 20, 2025 · 2 comments · May be fixed by #22399
Assignees
Labels
feature feature requests wallet-core Issues for mobile wallet team
Milestone

Comments

@shivekkhurana
Copy link
Contributor

Issue Description:

  • Currently while showing tokens in wallet, we consider ticker to be unique
  • Using the ticker, we group the balance across chains
  • But that's not true and there might be collisions, when two tokens have same ticker.
  • This will lead to incorrect grouping
  • In the past, we removed these colliding tokens manually
  • But with auto refresh tokens lists, this manual process has been removed
  • We need to update the logic on the client side to group by name, which is truly unique, not ticker

Acceptance Criteria:

The change is not visual, so hard to test.

  • The token grouping logic is updated to group by token name instead of ticker

Notes:

  • @saledjenic is handling this on Desktop side, in case help is needed
@shivekkhurana shivekkhurana added feature feature requests wallet-core Issues for mobile wallet team labels Mar 20, 2025
@shivekkhurana shivekkhurana added this to the 2.34.0 milestone Mar 20, 2025
@alwx alwx linked a pull request Mar 31, 2025 that will close this issue
@alwx
Copy link
Contributor

alwx commented Apr 16, 2025

status-go PR: status-im/status-go#6497
status-desktop PR: status-im/status-desktop#17771

@saledjenic
Copy link

Have to say that we've changed the plan a bit, and PRs referenced in the previous message will be either rebased (which will be very hard cause we've decided to add L1 chain before switching to CoinGecko and approach by using "id" and every single line will be a conflict) or reintroduced in a new PRs.

For 2.34 it was decided to solve the collision (both, symbol and decimal collisions) for the currently used tokens lists (Statsu, Aave, Uniswap) which is done in this PR status-im/status-go#6538

@churik churik modified the milestones: 2.34.0, 2.35.0 May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests wallet-core Issues for mobile wallet team
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants