From a30e137b4a753dcb5335f4a07fd0292386897ba4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adri=C3=A0=20Fontcuberta?= Date: Sat, 17 Aug 2019 20:16:22 +0200 Subject: [PATCH 1/3] Fix linting issue --- cypress/integration/commands.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cypress/integration/commands.spec.js b/cypress/integration/commands.spec.js index 15efba3..7b1c95a 100644 --- a/cypress/integration/commands.spec.js +++ b/cypress/integration/commands.spec.js @@ -40,7 +40,7 @@ describe('dom-testing-library commands', () => { }) it('getByText in container', () => { - cy.get('#nested').then(subject => { + return cy.get('#nested').then(subject => { cy.getByText('Button Text', {container: subject}).click() }) }) From 640b882fbd66d6ddf9a44b38746882bd49e85364 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adri=C3=A0=20Fontcuberta?= Date: Sat, 17 Aug 2019 20:39:44 +0200 Subject: [PATCH 2/3] Use config provided by cypress docs --- .travis.yml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index 5df248c..2d753a3 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,14 +3,18 @@ language: node_js addons: apt: packages: - - libgconf-2-4 + - libgconf-2-4 cache: + # Caches $HOME/.npm when npm ci is default script command + # Caches node_modules in all other cases + npm: true directories: - - ~/.npm + # we also need to cache folder with Cypress binary + - ~/.cache notifications: email: false node_js: '8' -install: npm install +install: npm ci script: npm run validate after_success: kcd-scripts travis-after-success branches: From 6cfadd2eb5d1578955967d922bf46a6a2fcbd466 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adri=C3=A0=20Fontcuberta?= Date: Sat, 17 Aug 2019 20:41:56 +0200 Subject: [PATCH 3/3] Can't use npm ci because package-lock isn't commited --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 2d753a3..52822ee 100644 --- a/.travis.yml +++ b/.travis.yml @@ -14,7 +14,7 @@ cache: notifications: email: false node_js: '8' -install: npm ci +install: npm install script: npm run validate after_success: kcd-scripts travis-after-success branches: