From 5e202ba23e1e240dd3efe6801bba9955f37a7632 Mon Sep 17 00:00:00 2001 From: Jovi De Croock Date: Wed, 8 Jun 2022 19:30:41 +0200 Subject: [PATCH 1/3] fix: pass arguments correctly --- src/fire-event.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/fire-event.js b/src/fire-event.js index 69d6a66..6129fba 100644 --- a/src/fire-event.js +++ b/src/fire-event.js @@ -5,14 +5,14 @@ import { fireEvent as domFireEvent, createEvent } from '@testing-library/dom' export const fireEvent = (...args) => domFireEvent(...args) Object.keys(domFireEvent).forEach((key) => { - fireEvent[key] = (elem) => { + fireEvent[key] = (element, init) => { // Preact registers event-listeners in lower-case, so onPointerStart becomes pointerStart // here we will copy this behavior, when we fire an element we will fire it in lowercase so // we hit the Preact listeners. const eventName = `on${key.toLowerCase()}` const isInElem = eventName in elem return isInElem - ? domFireEvent[key](elem) - : domFireEvent(elem, createEvent(key[0].toUpperCase() + key.slice(1), elem)) + ? domFireEvent[key](element, init) + : domFireEvent(elem, createEvent(key[0].toUpperCase() + key.slice(1), init)) } }) From 5640780ee2f949630a83f3c48cb9e72b5bb0b768 Mon Sep 17 00:00:00 2001 From: Jovi De Croock Date: Wed, 8 Jun 2022 19:35:40 +0200 Subject: [PATCH 2/3] fix: pass properties correctly --- src/fire-event.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/fire-event.js b/src/fire-event.js index 6129fba..91b611f 100644 --- a/src/fire-event.js +++ b/src/fire-event.js @@ -11,8 +11,10 @@ Object.keys(domFireEvent).forEach((key) => { // we hit the Preact listeners. const eventName = `on${key.toLowerCase()}` const isInElem = eventName in elem - return isInElem - ? domFireEvent[key](element, init) - : domFireEvent(elem, createEvent(key[0].toUpperCase() + key.slice(1), init)) + if (isInElem) { + return domFireEvent[key](element, init) + } else { + return domFireEvent(elem, createEvent(key[0].toUpperCase() + key.slice(1), element, init)) + } } }) From 8b931eaa3b7bb8b82bbfe9db9719d96dfd63608d Mon Sep 17 00:00:00 2001 From: Jovi De Croock Date: Wed, 8 Jun 2022 19:36:59 +0200 Subject: [PATCH 3/3] Update fire-event.js --- src/fire-event.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/fire-event.js b/src/fire-event.js index 91b611f..cce417b 100644 --- a/src/fire-event.js +++ b/src/fire-event.js @@ -5,16 +5,16 @@ import { fireEvent as domFireEvent, createEvent } from '@testing-library/dom' export const fireEvent = (...args) => domFireEvent(...args) Object.keys(domFireEvent).forEach((key) => { - fireEvent[key] = (element, init) => { + fireEvent[key] = (elem, init) => { // Preact registers event-listeners in lower-case, so onPointerStart becomes pointerStart // here we will copy this behavior, when we fire an element we will fire it in lowercase so // we hit the Preact listeners. const eventName = `on${key.toLowerCase()}` const isInElem = eventName in elem if (isInElem) { - return domFireEvent[key](element, init) + return domFireEvent[key](elem, init) } else { - return domFireEvent(elem, createEvent(key[0].toUpperCase() + key.slice(1), element, init)) + return domFireEvent(elem, createEvent(key[0].toUpperCase() + key.slice(1), elem, init)) } } })