cosmosdb test client 5s timeout with 7 min retry connect to container

Author: nopcoder

pkg/kv/cosmosdb/main_test.go

@@ -26,11 +26,11 @@ var (
 )
 
 func TestCosmosDB(t *testing.T) {
-	kvtest.DriverTest(t, func(t testing.TB, ctx context.Context) kv.Store {
-		if runtime.GOOS == "darwin" {
-			t.Skipf("this test hangs for macOS users, and fails. skipping - see Issue#8476 for more details")
-		}
+	if runtime.GOOS == "darwin" {
+		t.Skipf("this test hangs for macOS users, and fails. skipping - see Issue#8476 for more details")
+	}
 
+	kvtest.DriverTest(t, func(t testing.TB, ctx context.Context) kv.Store {
 		t.Helper()
 
 		databaseClient, err := client.NewDatabase(testParams.Database)

pkg/testutil/cosmosdb.go

@@ -13,7 +13,7 @@ import (
 
 const (
 	CosmosDBLocalPort = "8081"
-	maxWait           = 5 * time.Minute // Cosmosdb emulator takes time to start
+	maxWait           = 7 * time.Minute // Cosmosdb emulator takes time to start
 )
 
 var cosmosdbLocalURI string
@@ -59,16 +59,20 @@ func GetCosmosDBInstance() (string, func(), error) {
 		return "", nil, fmt.Errorf("joining urls: %w", err)
 	}
 
+	client := http.Client{
+		Transport: &http.Transport{
+			TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, //nolint:gosec // ignore self-signed cert for local testing using the emulator
+		},
+		Timeout: 5 * time.Second,
+	}
+
 	dockerPool.MaxWait = maxWait
 	log.Printf("Waiting up to %v for emulator to start", dockerPool.MaxWait)
 	// Note: this hangs for macOS users, and fails. See https://github.com/treeverse/lakeFS/issues/8476
 	err = dockerPool.Retry(func() error {
 		// waiting for cosmosdb container to be ready by issuing an HTTP get request with
 		// exponential backoff retry. The response is not really meaningful for that case
 		// and so is ignored
-		client := http.Client{Transport: &http.Transport{
-			TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, //nolint:gosec // ignore self-signed cert for local testing using the emulator
-		}}
 		resp, err := client.Get(p)
 		if err != nil {
 			return err