Skip to content

Removing dead code #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nhasabni opened this issue Nov 1, 2021 · 0 comments
Open

Removing dead code #443

nhasabni opened this issue Nov 1, 2021 · 0 comments

Comments

@nhasabni
Copy link

nhasabni commented Nov 1, 2021

Hi,

I work at Intel, and we have developed a tool that detects anomalous programming language expressions that can possibly lead to bugs. We scanned the code repository for this project as it has considerably high number of stars!

We found a place where the code/expressions are confusing and seem to implement the logic in a rather convoluted manner. We think that the expressions could be rewritten to capture the logic accurately and precisely.

Expression if(!saved_aid && 0) at https://github.com/vlm/asn1c/blob/master/libasn1parser/asn1p_y.c#L2655 seems like a dead code, if I am understanding the code correctly. Would it make sense to just remove the code in that case?

Any thoughts on the findings? If this looks acceptable, I'm happy to send a pull request with the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant