Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Commit 2e44e94

Browse files
committed
Merge branch '4.x' into ok/6701-Result-of-contract-method-.send-is-hard-to-type
2 parents fbd9f96 + 383af39 commit 2e44e94

File tree

17 files changed

+51
-44
lines changed

17 files changed

+51
-44
lines changed

CHANGELOG.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -179,13 +179,13 @@ Released with 1.0.0-beta.37 code base.
179179

180180
- Introduce review and release guidelines. (#3460)
181181
- Add EIP-1193 compatible provider to `AbstractProvider` interface. (#3499)
182-
- Add Typescript definitions for contract `methods` and `call`. (#3454)
182+
- Add TypeScript definitions for contract `methods` and `call`. (#3454)
183183
- Update AbstractProvider and contract.methods TS definitions (#3521)
184184
- Add support for ENS contenthash methods. (#3392, #2782)
185185

186186
### Changed
187187

188-
- Change CI provider from Travis to Github Actions. (#3468)
188+
- Change CI provider from Travis to GitHub Actions. (#3468)
189189
- Update `web3-eth-abi` ABICoder dependency. (#3490)
190190
- Update AbiCoder param formatting (#3522)
191191
- Improve code clarity of HttpProvider keepAlive option setting. (#3463)
@@ -354,7 +354,7 @@ Released with 1.0.0-beta.37 code base.
354354

355355
### Added
356356

357-
- Github action for running tests for `web3-eth2-core` and `web3-eth2-beaconchain` packages (#3892)
357+
- GitHub action for running tests for `web3-eth2-core` and `web3-eth2-beaconchain` packages (#3892)
358358
- Added description to documentation on how to connect using a remote node provider (#3884)
359359
- Added Security risk warning to docs for `web3.utils.soliditySha3` (#3908)
360360
- `.nvmrc` file using Node.js version `v.14.15.1` (#3817)
@@ -366,7 +366,7 @@ Released with 1.0.0-beta.37 code base.
366366
- Renamed the `tsc` script in all packages to `compile`; updates the corresponding `lerna run` usage in the main `package.json` (#3894)
367367
- moved deprecation warnings to postinstall scripts (#3917)
368368
- Upgrade `@chainsafe/geth-dev-assistant` from `0.1.5` to `0.1.9` (#3950)
369-
- Replaced hardcoded infura link with Github Secret for some tests (#3943)
369+
- Replaced hardcoded infura link with GitHub Secret for some tests (#3943)
370370
- Bump `elliptic` from `6.5.3` to `6.5.4` for `web3-eth-accounts` (#3941)
371371
- Bump `elliptic` from `6.5.3` to `6.5.4` for `web3-bzz` (#3940)
372372
- Bump `elliptic` from `6.5.3` to `6.5.4` for `web3-core-requestmanager` (#3945)
@@ -466,13 +466,13 @@ Released with 1.0.0-beta.37 code base.
466466

467467
- Not considering `tx.chainId` if `tx.common.customChain.chainId` is provided for `web3.eth.accounts.signTransaction` function (#4293)
468468
- Added missing PromiEvent handler types (#4194)
469-
- Updated README to include Webpack 5 angular support instructions (#4174)
469+
- Updated README to include webpack 5 angular support instructions (#4174)
470470
- Updated the documentation for the `Web3.utils`, removed context for `_` (underscore lib) (#4403)
471471
- Emit subscription id with connect event when creating a subscription (#4300)
472472
- Introduced new configuration "blockHeaderTimeout" for waiting of block headers for transaction receipt (#3891)
473473
- Format `block.baseFeePerGas` to number (#4330)
474474
- Correct `web3-eth-personal.sendTransaction` example in documentation (#4409)
475-
- Updated README to include Webpack 5 angular support instructions (#4174)
475+
- Updated README to include webpack 5 angular support instructions (#4174)
476476

477477
### Fixed
478478

@@ -509,7 +509,7 @@ Released with 1.0.0-beta.37 code base.
509509
- Fix typos in web3-utils.rst (#4662)
510510
- Added effectiveGasPrice to TransactionReceipt (#4692)
511511
- Correction in documentation for `web3.eth.accounts.signTransaction` (#4576)
512-
- Updated README to include Webpack 5 create-react-app support instructions (#4173)
512+
- Updated README to include webpack 5 create-react-app support instructions (#4173)
513513
- Update the documentation for `methods.myMethod.estimateGas` (#4702)
514514
- Fix typos in REVIEW.md and TESTING.md (#4691)
515515
- Fix encoding for "0x" string values (#4512)
@@ -562,7 +562,7 @@ Released with 1.0.0-beta.37 code base.
562562

563563
- Replace deprecated String.prototype.substr() (#4855)
564564
- Exporting AbiCoder as coder (#4937)
565-
- Github build workflow updated min build for node.js 12 and tests for 12, 14 and 16 (#5014)
565+
- GitHub build workflow updated min build for node.js 12 and tests for 12, 14 and 16 (#5014)
566566
- Updated libraries using BN and the BN library (#5072)
567567

568568
### Added
@@ -950,7 +950,7 @@ should use 4.0.1-alpha.0 for testing.
950950

951951
#### web3-validator
952952

953-
- Fix issue when importing `web3-validator` package within browser environments (Webpack minified filename changed from `index.min.js` to `web3-validator.min.js`) (#5710)
953+
- Fix issue when importing `web3-validator` package within browser environments (webpack minified filename changed from `index.min.js` to `web3-validator.min.js`) (#5710)
954954
- Fix build error '"type"' does not satisfy the constraint (#5712)
955955

956956
#### web3-eth-abi
@@ -2260,7 +2260,7 @@ If there are any bugs, improvements, optimizations or any new feature proposal f
22602260

22612261
#### web3-core
22622262

2263-
- Web3config `contractDataInputFill` has been defaulted to `data`, istead of `input`. (#6622)
2263+
- Web3config `contractDataInputFill` has been defaulted to `data`, instead of `input`. (#6622)
22642264

22652265
#### web3-eth-contracts
22662266

RELEASE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Further details about versioning can be found in the [semver 2.0.0 specification
2222

2323
### Running E2E Tests
2424

25-
`E2E Network Tests` will be triggered to run via a Github workflow when a PR is open for a branch prefixed with `release/` and is being merged into `4.x` branch. These tests depend on a couple of ENVs to be set that are configurable in Github's Action Secrets when running these tests in CI. The following required secrets are:
25+
`E2E Network Tests` will be triggered to run via a GitHub workflow when a PR is open for a branch prefixed with `release/` and is being merged into `4.x` branch. These tests depend on a couple of ENVs to be set that are configurable in GitHub's Action Secrets when running these tests in CI. The following required secrets are:
2626

2727
- `E2E_TESTS_ALLOWED_SEND_TRANSACTION`: If set to `false` this will keep the Sepolia tests that spend ETH from running, setting to anything else will cause them to run
2828
- `TEST_ACCOUNT_PRIVATE_KEY`: The private key of the Sepolia account to use when submitting transactions
@@ -50,7 +50,7 @@ Further details about versioning can be found in the [semver 2.0.0 specification
5050
8. `git tag bumped-version`: Tag the commit with bumped version having prefix `v` , e.g. `git tag v4.0.1-alpha.0`
5151
9. `git push origin release/bumped-version`: Push release branch to `origin`
5252
10. `git push origin --tags`: Push release tag created in `Step 8` to `origin`
53-
11. Create a draft release on Github similar to [this](https://github.com/web3/web3.js/releases/tag/v4.2.0)
53+
11. Create a draft release on GitHub similar to [this](https://github.com/web3/web3.js/releases/tag/v4.2.0)
5454

5555
- Select recently pushed tag in `choose a tag` drop down
5656

docs/README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
# Website
22

33
This website is built using [Docusaurus 2](https://docusaurus.io/), a modern static website generator.
4+
### Requirement
45

6+
Before getting started, ensure that you have ``Yarn`` installed on your machine.
7+
8+
[How to install Yarn](https://www.hostinger.com/tutorials/how-to-install-yarn)
59
### Installation
610

711
```

docs/docs/guides/getting_started/getting_started.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@ sidebar_label: Quickstart
66

77
# Quickstart
88

9+
10+
## Live code editor
11+
12+
<iframe width="100%" height="700px" src="https://stackblitz.com/edit/vitejs-vite-aksddx?embed=1&file=main.js&showSidebar=1"></iframe>
13+
914
## Installation
1015

1116
If NPM is being used as package manager, use the following for installing the web3.js library.
@@ -247,7 +252,3 @@ const subscription = uniswapToken.events.Transfer();
247252
subscription.on('data',console.log);
248253
// ↳ [{...},{...}, ...] live events will be printed in the console
249254
```
250-
251-
## Live code editor
252-
253-
<iframe width="100%" height="700px" src="https://stackblitz.com/edit/vitejs-vite-aksddx?embed=1&file=main.js&showSidebar=1"></iframe>

docs/docs/guides/glossary/index.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,24 +83,24 @@ contract Test {
8383
```json title='Resulting JSON ABI'
8484
[
8585
{
86-
"type": "constructor"
86+
"type": "constructor",
8787
"stateMutability": "nonpayable",
8888
"inputs": [{"internalType":"uint256","name":"testInt","type":"uint256"}],
8989
},
9090
{
91-
"type": "event"
91+
"type": "event",
9292
"name": "Event",
9393
"inputs": [{"indexed":true,"internalType":"uint256","name":"b","type":"uint256"},{"indexed":false,"internalType":"bytes32","name":"c","type":"bytes32"}],
9494
"anonymous": false,
9595
},
9696
{
97-
"type": "event"
97+
"type": "event",
9898
"name": "Event2",
9999
"inputs": [{"indexed":true,"internalType":"uint256","name":"b","type":"uint256"},{"indexed":false,"internalType":"bytes32","name":"c","type":"bytes32"}],
100100
"anonymous": false,
101101
},
102102
{
103-
"type": "function"
103+
"type": "function",
104104
"name": "foo",
105105
"stateMutability": "nonpayable",
106106
"inputs": [{"internalType":"uint256","name":"b","type":"uint256"},{"internalType":"bytes32","name":"c","type":"bytes32"}],

docs/docs/guides/hardhat_tutorial/index.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ Following the recent compatibility update of Hardhat plugin [hardhat-web3-v4](ht
1111
This tutorial will guide you through using Web3js as a plugin to interact with the Blockchain.
1212

1313
## Pre-requisite
14-
This tutorial assumes you have previous knowledge of writing Smart contracts, and are convenient working with Javascript/Typescript. You should have [NodeJS](https://nodejs.org/en) version greater than v16 installed.
14+
This tutorial assumes you have previous knowledge of writing Smart contracts, and are convenient working with JavaScript/TypeScript. You should have [NodeJS](https://nodejs.org/en) version greater than v16 installed.
1515

1616
:::note
1717
To install dependencies, we will use `NPM`.
@@ -49,7 +49,7 @@ npx hardhat init
4949

5050
### Install required dependencies (including `hardhat-web3-v4`)
5151

52-
Select `Typescript` and `Yes` for the rest of the options.
52+
Select `TypeScript` and `Yes` for the rest of the options.
5353
You will be prompted to install the required dependencies. Reply `yes` to complete the installation.
5454
To include the `Hardhat-web3-v4` plugin, we will install it via `npm`.
5555

docs/docs/guides/smart_contracts/infer_contract_types.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Web3.js is a popular library used for interacting with EVM blockchains. One of i
1414

1515
Before we dive into the problem, let's take a quick look at the problem. Web3.js provides a simple and convenient way to interact with Solidity contracts. To use Web3.js to interact with a Solidity contract, you need to know the contract's address and the ABI (Application Binary Interface) of the contract. The ABI is JSON data that contains the definition of the functions in the contract, including their, name, input parameters and return values.
1616

17-
Web3.js uses ABI type to dynamically load available methods and events but Typescript currently [doesn't support loading JSON as const](https://github.com/microsoft/TypeScript/issues/32063). If you go to the [Playground Link](https://www.typescriptlang.org/play?#code/MYewdgzgLgBAhgIwJYwLwwNoCga5gbxz1wCIkwAHAVyghIC5MjjdCWWywoBTAJzDgAbACoBPCtwYwS0XuQDmJADTN20gQFtJjEpu4B9ZavYko47dNkKSxvAF8VagreKce-IWIlSZUOWEVHJ3U4LR8IUQ0EEEFDIKdTc3C-axcYO1sAXXi8XzgeAFkaRCRBJDMfMHAKOFFEQUkc0jNvHVBIPypgKBBeG2IHVTYOOCqwSJAqOkYAMyEIbibpcmpaKWwnYYTyABNuAA9uHalOxbTScncBESSdOB2d3m4IOiXXPR8QAHcwPiNg6QtCwke6PZ50NKDTbnZZgPaHY6MU5vXKXPjXLzA0FPF7-YK6ULAiASOF-FHNW7SbHg-pqKFqLZqTjwo5SOaCBbk2FXTyUkhUS4AJgArAA2PEJD46ABuQiojRhiVa0gFXBF4shWSWBLCOgAghQKLwQLLBBLckCfNxpdwuLTcPTWLYQWMJlM2fMziYVjRpkxoQDmQdWUjePKuW50bzlSCHjjXoqpdIZsaNOaTJa7nGaZCUYzvaSEScw178WiPDcY9TcRGk6YQOmOJmqdncbm0vmOLtg4iYOzOYryxi+aqoOrG+9CT5TfKJxaR0KxfaWBl2NlnXXhLxRhAZmTnc2SNbbVBl47nAXVn6NgzB1wo5Wsa2E4G699fn0I4fqxCnOfiJ2rhDtGT5gjWiZTjoxK2nsn6Kt+z7LgMWobpBVKCII3yjMAComJMUBXusHZ3jyj4+KO461mhJBzhSMYUUumprtq0D5NwRRQCUZQVDKSDcF8jZKsCMxUGA3RIOAZ45J2nCEYwN7sIBqL3hWmI+D+tEhLqlgkrBmlCepiHtgGZYqcO9GLuKVHaSCGiTHaX4LmqjF-ihJh1nAhrGjagn4XJ-q3oGwFkTo0QxPpdb6YeYVmkxLDriYrGFMUyDcaIlTVLU9S4U2fIiWJUASWAUlDM6PprPJxFBWZIGGWBL74h5wCgKJp6OVWRmucxqE2QgQjYdwADyMy+TQ-kKSwSkXDVIUqpZEXUVFTlji5dJuRwSXsSlpTlOlvH8YJh75eJkmqOeMnldeCUcHWezAEgGjzKNBG+kRJnbDNak6KOAAcC02UtFlcH9cXENdribRxXG7dOfECdqR2iSdxVndJZWUK9lXvUywVfS29X-USun7oGCEE8ZgWmaReP8vN1lElQCB+HA3RHAAanKOUJIeDEal18Xard3DAE8cALHqGFYWJXO5H5mMBYpJEPjTMWEz4gPAqroN4ODuSQ9taUZZQWUIA0h15UjhWnQMaOXvLE0AUrql8hp9PhMTcGky7nV0nmTvmcCvNq1mew7Bzgizu1gfzdruC66QdbkCL3Bi9wEuYV8A3PeNVVU8rfKq27Ogaz4Wv82DLGcclnGpTDOhjDUdSmzLdHCZbRUlY7dsVZg8dacCHzanLPcO3gU3cvnMZWAEwfSCXUEpDPscwH3eTV9DPHSNKcPmzGx1WyjNuld3V2C9RERROFQ9jfbucfdTfLT4EEEA1HyT+Ioy+r-rNc7ZvJDbwOgjC2BUO6o2Pl2DGI9V51h6JxQQABlKghpBDpWvi9Eed8cafWWpRF+wJ55zWcnzNa3VEpVy2r-Q2+14YHhAcjTuY90Y52xgWB+HUCZF0BA2N+Id4xIXsH7aq7Do7ENnrZeybV4K4NWuwVcAserAmZpAPcnsODD2vFgthk9NYgCvvg9WvDpBl1IQo8hbEoa13-g3E2ZtgF73btbQRECgJQM0awyBIi6r8K4SQFMIA0xGNjOTP8Qi87Ow4T4gxOgeiEOCfwimithE6PInTaJVI7KtTiUHL+Z8bLKN3HwAAYqmbOt8PGuK8aFPRZpfFxJMXI9aEMKGWL-ntdQmUm52LoQ40BTiHREEyPACAMB2jQAANxAA) and choose '.d.ts' you can check type difference with and without `as const`.
17+
Web3.js uses ABI type to dynamically load available methods and events but TypeScript currently [doesn't support loading JSON as const](https://github.com/microsoft/TypeScript/issues/32063). If you go to the [Playground Link](https://www.typescriptlang.org/play?#code/MYewdgzgLgBAhgIwJYwLwwNoCga5gbxz1wCIkwAHAVyghIC5MjjdCWWywoBTAJzDgAbACoBPCtwYwS0XuQDmJADTN20gQFtJjEpu4B9ZavYko47dNkKSxvAF8VagreKce-IWIlSZUOWEVHJ3U4LR8IUQ0EEEFDIKdTc3C-axcYO1sAXXi8XzgeAFkaRCRBJDMfMHAKOFFEQUkc0jNvHVBIPypgKBBeG2IHVTYOOCqwSJAqOkYAMyEIbibpcmpaKWwnYYTyABNuAA9uHalOxbTScncBESSdOB2d3m4IOiXXPR8QAHcwPiNg6QtCwke6PZ50NKDTbnZZgPaHY6MU5vXKXPjXLzA0FPF7-YK6ULAiASOF-FHNW7SbHg-pqKFqLZqTjwo5SOaCBbk2FXTyUkhUS4AJgArAA2PEJD46ABuQiojRhiVa0gFXBF4shWSWBLCOgAghQKLwQLLBBLckCfNxpdwuLTcPTWLYQWMJlM2fMziYVjRpkxoQDmQdWUjePKuW50bzlSCHjjXoqpdIZsaNOaTJa7nGaZCUYzvaSEScw178WiPDcY9TcRGk6YQOmOJmqdncbm0vmOLtg4iYOzOYryxi+aqoOrG+9CT5TfKJxaR0KxfaWBl2NlnXXhLxRhAZmTnc2SNbbVBl47nAXVn6NgzB1wo5Wsa2E4G699fn0I4fqxCnOfiJ2rhDtGT5gjWiZTjoxK2nsn6Kt+z7LgMWobpBVKCII3yjMAComJMUBXusHZ3jyj4+KO461mhJBzhSMYUUumprtq0D5NwRRQCUZQVDKSDcF8jZKsCMxUGA3RIOAZ45J2nCEYwN7sIBqL3hWmI+D+tEhLqlgkrBmlCepiHtgGZYqcO9GLuKVHaSCGiTHaX4LmqjF-ihJh1nAhrGjagn4XJ-q3oGwFkTo0QxPpdb6YeYVmkxLDriYrGFMUyDcaIlTVLU9S4U2fIiWJUASWAUlDM6PprPJxFBWZIGGWBL74h5wCgKJp6OVWRmucxqE2QgQjYdwADyMy+TQ-kKSwSkXDVIUqpZEXUVFTlji5dJuRwSXsSlpTlOlvH8YJh75eJkmqOeMnldeCUcHWezAEgGjzKNBG+kRJnbDNak6KOAAcC02UtFlcH9cXENdribRxXG7dOfECdqR2iSdxVndJZWUK9lXvUywVfS29X-USun7oGCEE8ZgWmaReP8vN1lElQCB+HA3RHAAanKOUJIeDEal18Xard3DAE8cALHqGFYWJXO5H5mMBYpJEPjTMWEz4gPAqroN4ODuSQ9taUZZQWUIA0h15UjhWnQMaOXvLE0AUrql8hp9PhMTcGky7nV0nmTvmcCvNq1mew7Bzgizu1gfzdruC66QdbkCL3Bi9wEuYV8A3PeNVVU8rfKq27Ogaz4Wv82DLGcclnGpTDOhjDUdSmzLdHCZbRUlY7dsVZg8dacCHzanLPcO3gU3cvnMZWAEwfSCXUEpDPscwH3eTV9DPHSNKcPmzGx1WyjNuld3V2C9RERROFQ9jfbucfdTfLT4EEEA1HyT+Ioy+r-rNc7ZvJDbwOgjC2BUO6o2Pl2DGI9V51h6JxQQABlKghpBDpWvi9Eed8cafWWpRF+wJ55zWcnzNa3VEpVy2r-Q2+14YHhAcjTuY90Y52xgWB+HUCZF0BA2N+Id4xIXsH7aq7Do7ENnrZeybV4K4NWuwVcAserAmZpAPcnsODD2vFgthk9NYgCvvg9WvDpBl1IQo8hbEoa13-g3E2ZtgF73btbQRECgJQM0awyBIi6r8K4SQFMIA0xGNjOTP8Qi87Ow4T4gxOgeiEOCfwimithE6PInTaJVI7KtTiUHL+Z8bLKN3HwAAYqmbOt8PGuK8aFPRZpfFxJMXI9aEMKGWL-ntdQmUm52LoQ40BTiHREEyPACAMB2jQAANxAA) and choose '.d.ts' you can check type difference with and without `as const`.
1818

1919
```typescript
2020
import { Contract, Web3 } from 'web3';
@@ -32,7 +32,7 @@ import ERC20 from './node_modules/@openzeppelin/contracts/build/contracts/ERC20.
3232
})();
3333
```
3434

35-
To work around it you need to copy abi into a Typescript file like this:
35+
To work around it you need to copy abi into a TypeScript file like this:
3636

3737
```typescript
3838
import {Contract, Web3} from 'web3';

docs/docs/guides/wallet/index.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ sidebar_label: 'Mastering Wallets & Accounts'
55

66
# Wallets and Accounts Overview
77

8+
9+
## Live code editor
10+
11+
<iframe width="100%" height="700px" src="https://stackblitz.com/edit/vitejs-vite-mhuwrk?embed=1&file=main.js&showSidebar=1"></iframe>
12+
813
## Introduction
914

1015
A Web3.js `Wallet` is your main entry point if you want to use a private key directly to do any blockchain operations (transactions), also called `Signer` in other libraries.
@@ -220,7 +225,3 @@ The following is a list of `Accounts` [methods](/libdocs/Wallet) in the `web3.et
220225
- [sign](/libdocs/Accounts#sign)
221226
- [signTransaction](/libdocs/Accounts#signtransaction)
222227

223-
224-
## Live code editor
225-
226-
<iframe width="100%" height="700px" src="https://stackblitz.com/edit/vitejs-vite-mhuwrk?embed=1&file=main.js&showSidebar=1"></iframe>

docs/docs/guides/web3_providers_guide/index.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ sidebar_label: 'Mastering Providers'
55

66
# Web3js providers overview
77

8+
9+
## Live code editor
10+
11+
<iframe width="100%" height="700px" src="https://stackblitz.com/edit/vitejs-vite-zfusfd?embed=1&file=main.js&showSidebar=1"></iframe>
12+
813
## Introduction
914

1015
web3.js providers are objects responsible for enabling connectivity with the Ethereum network in various ways. Connecting your web application to an Ethereum node is necessary for sending transactions, querying data, and interacting with smart contracts on the network. In this guide, we will explore the different types of providers available in web3.js, how to set them up, and how to use them in your code.
@@ -375,7 +380,3 @@ provider.on('error', (error) => {
375380
```
376381

377382

378-
379-
## Live code editor
380-
381-
<iframe width="100%" height="700px" src="https://stackblitz.com/edit/vitejs-vite-zfusfd?embed=1&file=main.js&showSidebar=1"></iframe>

packages/web3-eth-accounts/src/common/common.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -903,7 +903,7 @@ export class Common extends EventEmitter {
903903
// eslint-disable-next-line no-null/no-null
904904
hf.block === null || (hf.ttd !== undefined && hf.ttd !== null) ? 0 : hf.block,
905905
);
906-
// Typescript can't seem to follow that the hfBlock is not null at this point
906+
// TypeScript can't seem to follow that the hfBlock is not null at this point
907907
// eslint-disable-next-line no-null/no-null
908908
return block > hfBlock! && acc === null ? block : acc;
909909
// eslint-disable-next-line no-null/no-null

packages/web3-eth-contract/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,9 @@ const contract = new Contract(abi);
5858

5959
## Compatibility
6060

61-
We have tested the Typescript interface support for the ABIs compiled with solidity version `v0.4.x` and above. If you face any issue regarding the contract typing, please create an issue to report to us.
61+
We have tested the TypeScript interface support for the ABIs compiled with solidity version `v0.4.x` and above. If you face any issue regarding the contract typing, please create an issue to report to us.
6262

63-
The Typescript support for fixed length array types are supported up 30 elements. See more details [here](https://github.com/ChainSafe/web3.js/blob/nh%2F4562-contract-typing/packages/web3-eth-abi/src/number_map_type.ts#L1). This limitation is only to provide more performant developer experience in IDEs. In future we may come up with a workaround to avoid this limitation. If you have any idea feel free to share.
63+
The TypeScript support for fixed length array types are supported up 30 elements. See more details [here](https://github.com/ChainSafe/web3.js/blob/nh%2F4562-contract-typing/packages/web3-eth-abi/src/number_map_type.ts#L1). This limitation is only to provide more performant developer experience in IDEs. In future we may come up with a workaround to avoid this limitation. If you have any idea feel free to share.
6464

6565
## Package.json Scripts
6666

packages/web3-eth-contract/src/contract.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ export class Contract<Abi extends ContractAbi>
413413
* });
414414
* ```
415415
*
416-
* To use the type safe interface for these contracts you have to include the ABI definitions in your Typescript project and then declare these as `const`.
416+
* To use the type safe interface for these contracts you have to include the ABI definitions in your TypeScript project and then declare these as `const`.
417417
*
418418
* ```ts title="Example"
419419
* const myContractAbi = [....] as const; // ABI definitions

packages/web3-eth-contract/test/integration/contract_defaults_extra.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ describe('contract defaults (extra)', () => {
236236
});
237237

238238
describeIf(isWs)('blockHeaderTimeout', () => {
239-
it('should use "blockHeaderTimout" on "instance" level', async () => {
239+
it('should use "blockHeaderTimeout" on "instance" level', async () => {
240240
contract = new Contract(GreeterAbi, undefined, {
241241
provider: getSystemTestProvider(),
242242
});

0 commit comments

Comments
 (0)