From b3a4514882d1ac9ea032b5a1ee3426af3ad0cbd8 Mon Sep 17 00:00:00 2001 From: Koichi Kobayashi Date: Sat, 3 May 2025 18:14:59 +0900 Subject: [PATCH] Fixed proliferation of resultList in GetAsync --- src/redmine-net-api/RedmineManagerAsync.cs | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/src/redmine-net-api/RedmineManagerAsync.cs b/src/redmine-net-api/RedmineManagerAsync.cs index f7060e5a..a1f066ea 100644 --- a/src/redmine-net-api/RedmineManagerAsync.cs +++ b/src/redmine-net-api/RedmineManagerAsync.cs @@ -141,17 +141,22 @@ public async Task> GetAsync(RequestOptions requestOptions = null, Can TaskExtensions.WhenAll(pageFetchTasks) #endif .ConfigureAwait(false); - - foreach (var pageResult in pageResults) + + if (pageResults.Length == 0) + { + return resultList; + } + else { - if (pageResult?.Items == null) + resultList = new List(); + foreach (var pageResult in pageResults) { - continue; + if (pageResult?.Items == null) + { + continue; + } + resultList.AddRange(pageResult.Items); } - - resultList ??= new List(); - - resultList.AddRange(pageResult.Items); } } }