chore: misc minor fixes (#1733)

ymc9 · web-flow · commit 9fb8d5b34622 · 2024-09-22T21:46:39.000-07:00
diff --git a/packages/runtime/src/enhancements/node/query-utils.ts b/packages/runtime/src/enhancements/node/query-utils.ts
@@ -225,7 +225,7 @@ export class QueryUtils {
             // model has a discriminator so it can be a polymorphic base,
             // need to find the concrete model
             const concreteModelName = data[modelInfo.discriminator];
-            if (concreteModelName) {
+            if (typeof concreteModelName === 'string' && concreteModelName) {
                 return concreteModelName;
             }
         }
diff --git a/tests/regression/tests/issue-1698.test.ts b/tests/regression/tests/issue-1698.test.ts
@@ -1,5 +1,5 @@
 import { loadSchema } from '@zenstackhq/testtools';
-describe('issue 1968', () => {
+describe('issue 1698', () => {
     it('regression', async () => {
         const { enhance } = await loadSchema(
             `

Original file line number	Diff line number	Diff line change
`@@ -225,7 +225,7 @@ export class QueryUtils {`
`225`	`225`	`// model has a discriminator so it can be a polymorphic base,`
`226`	`226`	`// need to find the concrete model`
`227`	`227`	`const concreteModelName = data[modelInfo.discriminator];`
`228`		`- if (concreteModelName) {`
	`228`	`+ if (typeof concreteModelName === 'string' && concreteModelName) {`
`229`	`229`	`return concreteModelName;`
`230`	`230`	`}`
`231`	`231`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`import { loadSchema } from '@zenstackhq/testtools';`
`2`		`-describe('issue 1968', () => {`
	`2`	`+describe('issue 1698', () => {`
`3`	`3`	`it('regression', async () => {`
`4`	`4`	`const { enhance } = await loadSchema(`
`5`	`5`	`