Simplify id fields @default check

thomassnielsen · thomassnielsen · commit de8aefab125e · 2024-11-16T21:08:25.000+01:00
diff --git a/packages/plugins/openapi/src/rest-generator.ts b/packages/plugins/openapi/src/rest-generator.ts
@@ -905,7 +905,7 @@ export class RESTfulOpenAPIGenerator extends OpenAPIGeneratorBase {
         if (mode === 'create') {
             // 'id' is required if there's no default value
             const idFields = model.fields.filter((f) => isIdField(f));
-            if (idFields.length === 1 && idFields.every((f) => !hasAttribute(f, '@default'))) {
+            if (idFields.length === 1 && !hasAttribute(idFields[0], '@default')) {
                 properties = { id: { type: 'string' }, ...properties };
                 toplevelRequired.unshift('id');
             }

Original file line number	Diff line number	Diff line change
`@@ -905,7 +905,7 @@ export class RESTfulOpenAPIGenerator extends OpenAPIGeneratorBase {`
`905`	`905`	`if (mode === 'create') {`
`906`	`906`	`// 'id' is required if there's no default value`
`907`	`907`	`const idFields = model.fields.filter((f) => isIdField(f));`
`908`		`- if (idFields.length === 1 && idFields.every((f) => !hasAttribute(f, '@default'))) {`
	`908`	`+ if (idFields.length === 1 && !hasAttribute(idFields[0], '@default')) {`
`909`	`909`	`properties = { id: { type: 'string' }, ...properties };`
`910`	`910`	`toplevelRequired.unshift('id');`
`911`	`911`	`}`