Skip to content

Commit 2023fbb

Browse files
committed
fix internal go skew from upstream/main
1 parent 83f3958 commit 2023fbb

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

internal/compiler/emitter.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,8 @@ func (e *emitter) emit() {
4949
e.emitBuildInfo(e.paths.BuildInfoPath())
5050
}
5151

52-
func (e *emitter) getDeclarationTransformers(emitContext *printer.EmitContext, sourceFile *ast.SourceFile, declarationFilePath string, declarationMapPath string) []*declarations.DeclarationTransformer {
53-
emitResolver := e.host.GetEmitResolver(sourceFile, false /*skipDiagnostics*/) // !!! conditionally skip diagnostics
54-
transform := declarations.NewDeclarationTransformer(e.host, emitResolver, emitContext, e.host.Options(), declarationFilePath, declarationMapPath)
52+
func (e *emitter) getDeclarationTransformers(emitContext *printer.EmitContext, declarationFilePath string, declarationMapPath string) []*declarations.DeclarationTransformer {
53+
transform := declarations.NewDeclarationTransformer(e.host, emitContext, e.host.Options(), declarationFilePath, declarationMapPath)
5554
return []*declarations.DeclarationTransformer{transform}
5655
}
5756

@@ -86,7 +85,7 @@ func getScriptTransformers(emitContext *printer.EmitContext, host printer.EmitHo
8685
var emitResolver printer.EmitResolver
8786
var referenceResolver binder.ReferenceResolver
8887
if importElisionEnabled || options.GetJSXTransformEnabled() {
89-
emitResolver = host.GetEmitResolver(sourceFile, false /*skipDiagnostics*/) // !!! conditionally skip diagnostics
88+
emitResolver = host.GetEmitResolver()
9089
emitResolver.MarkLinkedReferencesRecursively(sourceFile)
9190
referenceResolver = emitResolver
9291
} else {
@@ -179,7 +178,7 @@ func (e *emitter) emitDeclarationFile(sourceFile *ast.SourceFile, declarationFil
179178
var diags []*ast.Diagnostic
180179
emitContext, putEmitContext := printer.GetEmitContext()
181180
defer putEmitContext()
182-
for _, transformer := range e.getDeclarationTransformers(emitContext, sourceFile, declarationFilePath, declarationMapPath) {
181+
for _, transformer := range e.getDeclarationTransformers(emitContext, declarationFilePath, declarationMapPath) {
183182
sourceFile = transformer.TransformSourceFile(sourceFile)
184183
diags = append(diags, transformer.GetDiagnostics()...)
185184
}
@@ -378,6 +377,7 @@ type SourceFileMayBeEmittedHost interface {
378377
IsSourceFileFromExternalLibrary(file *ast.SourceFile) bool
379378
GetCurrentDirectory() string
380379
UseCaseSensitiveFileNames() bool
380+
SourceFiles() []*ast.SourceFile
381381
}
382382

383383
func sourceFileMayBeEmitted(sourceFile *ast.SourceFile, host SourceFileMayBeEmittedHost, forceDtsEmit bool) bool {
@@ -435,7 +435,7 @@ func sourceFileMayBeEmitted(sourceFile *ast.SourceFile, host SourceFileMayBeEmit
435435
return true
436436
}
437437

438-
func getSourceFilesToEmit(host printer.EmitHost, targetSourceFile *ast.SourceFile, forceDtsEmit bool) []*ast.SourceFile {
438+
func getSourceFilesToEmit(host SourceFileMayBeEmittedHost, targetSourceFile *ast.SourceFile, forceDtsEmit bool) []*ast.SourceFile {
439439
// !!! outFile not yet implemented, may be deprecated
440440
var sourceFiles []*ast.SourceFile
441441
if targetSourceFile != nil {
@@ -452,13 +452,13 @@ func isSourceFileNotJson(file *ast.SourceFile) bool {
452452
return !ast.IsJsonSourceFile(file)
453453
}
454454

455-
func getDeclarationDiagnostics(host EmitHost, resolver printer.EmitResolver, file *ast.SourceFile) []*ast.Diagnostic {
455+
func getDeclarationDiagnostics(host EmitHost, file *ast.SourceFile) []*ast.Diagnostic {
456456
fullFiles := core.Filter(getSourceFilesToEmit(host, file, false), isSourceFileNotJson)
457457
if !core.Some(fullFiles, func(f *ast.SourceFile) bool { return f == file }) {
458458
return []*ast.Diagnostic{}
459459
}
460460
options := host.Options()
461-
transform := declarations.NewDeclarationTransformer(host, resolver, nil, options, "", "")
461+
transform := declarations.NewDeclarationTransformer(host, nil, options, "", "")
462462
transform.TransformSourceFile(file)
463463
return transform.GetDiagnostics()
464464
}

0 commit comments

Comments
 (0)