added meta.tsv, updated documentation, fixed calendar import #146
Conversation
…into IngoS11/doc_errors
added an example meta.tsv file that can be used for the hubble-data repository. Update the README.md to tell people that a meta.tsv file has to be present inside hubble-data. Added an Exception and print output in case there is no meta.tsv file. Fixed missing inmport statement in ReportPRUsage.py for callendar
…into IngoS11/doc_errors
|
@IngoS11: Thanks for these patches! I believe that it would be best to handle empty Aside from that, I’ll look into the |
| @@ -20,6 +20,9 @@ def checkSchemaVersion(dataDirectory): | |||
| if row[0] == "schema-version": | |||
| schemaVersionLocal = int(row[1]) | |||
| break | |||
| except IOError: | |||
| print("error: the data repository has no file named meta.tsv", file = sys.stderr) | |||
| sys.exit(1) | |||
There was a problem hiding this comment.
👋 @IngoS11 ! Thanks for fixing this issue!
I wonder, couldn't we just assume the default schemaVersion in case of an IOError? That means we would set:
schemaVersionLocal = schemaVersion
here.
What do you think?
|
@IngoS11: Thanks for your contributions. I think that it’s nicer to add support for empty For this reason, I decided to split your pull request into the Again, thanks for helping us out, and I hope that you’re fine with me closing this pull request, now that it’s superseded by #152 and #153. Just on a side note, feel free to open separate pull requests even for minor things such as the |
added an example meta.tsv file that can be used for the hubble-data repository. Update the README.md to tell people that a meta.tsv file has to be present inside hubble-data. Added an Exception and print output in case there is no meta.tsv file. Fixed missing import statement in ReportPRUsage.py for calendar