Skip to content

fix: [NPM] [CVEs] [v1.5] Update Ubuntu Image to 24.04 and Revert Manual NPM Linux Dockerfile Package Installations #3679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: release/v1.5
Choose a base branch
from
Open

fix: [NPM] [CVEs] [v1.5] Update Ubuntu Image to 24.04 and Revert Manual NPM Linux Dockerfile Package Installations #3679

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fb3ce45
fix: [NPM] Reduce/Refactor Noisy NPM Logs (#3468)
rayaisaiah Mar 11, 2025
284a4d7
Merge branch 'release/v1.5' of https://github.com/Azure/azure-contain…
rayaisaiah Mar 20, 2025
169b542
Merge branch 'release/v1.5' of https://github.com/Azure/azure-contain…
rayaisaiah Mar 21, 2025
b184664
Merge branch 'release/v1.5' of https://github.com/Azure/azure-contain…
rayaisaiah Mar 31, 2025
a45273e
Merge branch 'release/v1.5' of https://github.com/Azure/azure-contain…
rayaisaiah Apr 29, 2025
5e58eab
Merge branch 'release/v1.5' of https://github.com/Azure/azure-contain…
rayaisaiah May 22, 2025
ead064c
removed hardcoded package versions from npm dockerfile
rayaisaiah May 22, 2025
391f16b
Merge branch 'release/v1.5' of https://github.com/Azure/azure-contain…
rayaisaiah May 27, 2025
dea9101
Merge branch 'release/v1.5' into isaiahraya/npm-remove-hardcoded-pack…
rayaisaiah May 27, 2025
2153553
update linux to 24.04
rayaisaiah Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions npm/linux.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ WORKDIR /usr/local/src
COPY . .
RUN CGO_ENABLED=0 go build -v -o /usr/local/bin/azure-npm -ldflags "-X main.version="$VERSION" -X "$NPM_AI_PATH"="$NPM_AI_ID"" -gcflags="-dwarflocationlists=true" npm/cmd/*.go

FROM mcr.microsoft.com/mirror/docker/library/ubuntu:20.04
FROM mcr.microsoft.com/mirror/docker/library/ubuntu:24.04
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cyclonus run on the 24.04 image also failed quite a few tests (75% for first run 66% for second). because of this i think at a later time we should probably dedicate some cycles to seeing the iprule/ipset differences between the Ubuntu versions to see what is causing this drop. Maybe use Ubuntu 22.04?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued a run directly from the cyclonus pipeline here: https://github.com/Azure/azure-container-networking/actions/runs/15448171797

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

green on second run: https://github.com/Azure/azure-container-networking/actions/runs/15449432372

COPY --from=builder /usr/local/bin/azure-npm /usr/bin/azure-npm
RUN apt-get update && apt-get install -y libc-bin=2.31-0ubuntu9.17 libc6=2.31-0ubuntu9.17 libtasn1-6=4.16.0-2ubuntu0.1 libgnutls30=3.6.13-2ubuntu1.12 iptables ipset ca-certificates && apt-get autoremove -y && apt-get clean
RUN apt-get update && apt-get install -y iptables ipset ca-certificates && apt-get autoremove -y && apt-get clean
RUN chmod +x /usr/bin/azure-npm
ENTRYPOINT ["/usr/bin/azure-npm", "start"]
Loading