Skip to content

Add js string codebytes #2580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 28, 2023

Conversation

mehboobali98
Copy link
Contributor

@mehboobali98 mehboobali98 commented Jun 24, 2023

Description

This closes (#2513)
Added codebyte examples to string .charAt(), .concat() and .indexOf() methods.

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

@SSwiniarski SSwiniarski linked an issue Jun 24, 2023 that may be closed by this pull request
3 tasks
@SSwiniarski SSwiniarski self-assigned this Jun 24, 2023
@SSwiniarski SSwiniarski added enhancement New feature or request javascript JavaScript entries status: under review Issue or PR is currently being reviewed labels Jun 24, 2023
Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehboobali98 I did a first review and left a couple of comments.

@mehboobali98
Copy link
Contributor Author

@SSwiniarski Resolved the comments.

Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehboobali98 looks good for a second review.

Copy link
Contributor

@caupolicandiaz caupolicandiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehboobali98 @SSwiniarski I've added a few additional edits to these entries. Looks good to go.

@SSwiniarski SSwiniarski merged commit ecd416f into Codecademy:main Jun 28, 2023
@github-actions
Copy link

👋 @mehboobali98
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Edit] JavaScript Add Codebytes
3 participants