Skip to content

Codebyte examples for Javascript Promise.all and finally #2601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 28, 2023
Merged

Codebyte examples for Javascript Promise.all and finally #2601

merged 5 commits into from
Jun 28, 2023

Conversation

carlos-ds
Copy link
Contributor

Description

  • Added Codebyte examples for Javascript Promise.all and finally.
  • Fixed a typo in the existing entry for Promise.all.

Closes #2510

Type of Change

Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

@carlos-ds carlos-ds changed the title #2510 add codebytes for javascript promise all and finally Codebyte examples for Javascript Promise.all and finally Jun 27, 2023
@SSwiniarski SSwiniarski self-assigned this Jun 27, 2023
@SSwiniarski SSwiniarski added enhancement New feature or request javascript JavaScript entries status: under review Issue or PR is currently being reviewed labels Jun 27, 2023
SSwiniarski
SSwiniarski approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlos-ds Looks good as is. I'm passing this on to a second review.

@caupolicandiaz caupolicandiaz added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Jun 27, 2023
caupolicandiaz
caupolicandiaz approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@caupolicandiaz caupolicandiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlos-ds @SSwiniarski Added some additional edits. Looks good to merge.

@caupolicandiaz caupolicandiaz added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Jun 27, 2023
@SSwiniarski SSwiniarski merged commit 248d224 into Codecademy:main Jun 28, 2023
@github-actions
Copy link

👋 @carlos-ds
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

@SSwiniarski
Copy link
Contributor

@carlos-ds Congrats on the new edits!

Live links:

carlos-ds added a commit to carlos-ds/codecademy-docs that referenced this pull request Jul 17, 2023
@carlos-ds
Codecademy#2511 redact Codebyte examples for Promise.race and Promise…
e45883d 
….reject based on feedback on a previous PR (Codecademy#2601)
KTom101 pushed a commit that referenced this pull request Aug 17, 2023
@carlos-ds
#2511 add codebytes for javascript promise race and reject (#2778)
b8e565c 
* #2511 add Codebyte example for Promise.race

* #2511 add Codebyte example for Promise.reject

* #2511 redact Codebyte examples for Promise.race and Promise.reject based on feedback on a previous PR (#2601)

* Update race.md

* Update race.md

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caupolicandiaz caupolicandiaz caupolicandiaz approved these changes

@SSwiniarski SSwiniarski SSwiniarski approved these changes

Assignees

@SSwiniarski SSwiniarski

Labels
enhancement New feature or request javascript JavaScript entries status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Edit] JavaScript Add Codebytes
3 participants
@carlos-ds @SSwiniarski @caupolicandiaz