feat(mobile): Send messages through http #12037
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Minion3665
force-pushed
the
private/skyler/push-xrluwxmpnoyn
branch
from
732d2cc to
6c56429
Compare
6 tasks
Minion3665
force-pushed
the
private/skyler/push-xrluwxmpnoyn
branch
from
6c56429 to
ecb9f17
Compare
|
I've discovered some more issues here, particularly notably a failure in Android (not iOS) to start presentations. This needs some more work before it is merged |
|
@kendy could you review the code? |
|
Probably not quite relevant yet - I'm going to be using the ProxySocket method rather than this one as I'm not sure it's possible to flush this buffer properly on Android - maybe best to wait for review after that is a little more done |
|
high level stuff - i.e. general method of using cool: protocol handling - will stay, but at least the long HTTP handling code will change |
Minion3665
force-pushed
the
private/skyler/push-xrluwxmpnoyn
branch
from
ecb9f17 to
8426273
Compare
I'm about to write some code that will use multiple different endpoints in the cool: protocol Right now, we're only using this for accessing video so we haven't checked the path, but all media requests still use cool:/cool/media as their path. Therefore, we can match on that and give a 404 on any other path Signed-off-by: Skyler Grey <skyler.grey@collabora.com> Change-Id: I95f1328d6345f2a42d4205d25d320f4396df04a6
In the same vein as I95f1328d6345f2a42d4205d25d320f4396df04a6 which did this for Android, I'm about to write some code that will use multiple different endpoints in the cool: protocol Right now, we're only using this for accessing video so we haven't checked the path, but all media requests still use cool:/cool/media as their path. Therefore, we can match on that and give a 404 on any other path
Once again, we need this to build more iOS snapshots - since as we've released something on 2504.0.3 already Signed-off-by: Skyler Grey <skyler.grey@collabora.com> Change-Id: I2541c111f231c665bd56798339d9be70c1c3e68d
Minion3665
force-pushed
the
private/skyler/push-xrluwxmpnoyn
branch
from
072fbf8 to
bb379d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.