Skip to content

Add more analyzers, enable unit tests for partial properties #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Dec 3, 2024

Conversation

Sergio0694
Copy link
Member

This PR introduces the following changes:

  • Add more analyzers for partial properties
  • Add more analyzer tests
  • Copy all [ObservableProperty] field tests and enable them for partial properties too

Note

One of the new tests is blocked by dotnet/roslyn#76166.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added testing 🏗️ Issues or changes related to testing infrastructure mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit analyzer 👓 A new analyzer being implemented or updated labels Nov 30, 2024
@Sergio0694 Sergio0694 changed the title Dev/more analyzers Add more analyzers, enable unit tests for partial properties Nov 30, 2024
@Sergio0694 Sergio0694 merged commit 28c6a8c into main Dec 3, 2024
3 checks passed
@Sergio0694 Sergio0694 deleted the dev/more-analyzers branch December 3, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer 👓 A new analyzer being implemented or updated mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit testing 🏗️ Issues or changes related to testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant