Skip to content

Move some diagnostics to analyzers #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 28, 2024
Merged

Move some diagnostics to analyzers #968

merged 3 commits into from
Oct 28, 2024

Conversation

Sergio0694
Copy link
Member

This PR moves some diagnostics from the [ObservableProperty] generator, to diagnostic analyzers.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added optimization ☄ Performance or memory usage improvements mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit analyzer 👓 A new analyzer being implemented or updated labels Oct 28, 2024
@Sergio0694 Sergio0694 force-pushed the dev/move-diagnostics-to-analyzers branch from 2b914e6 to 143df8e Compare October 28, 2024 01:09
@Sergio0694 Sergio0694 merged commit 812f545 into main Oct 28, 2024
3 checks passed
@Sergio0694 Sergio0694 deleted the dev/move-diagnostics-to-analyzers branch October 28, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analyzer 👓 A new analyzer being implemented or updated mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit optimization ☄ Performance or memory usage improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sergio0694