-
Notifications
You must be signed in to change notification settings - Fork 45
Run Integration Tests in GitHub #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarcyRaynerDD
approved these changes
Mar 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but i think we should double check the output of the error test function
tests/integration/snapshots/return_values/http-error_python27_api-gateway-get.json
Outdated
Show resolved
Hide resolved
This was referenced Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
stage
parameter to create a new/separate CloudFormation stack for each run of the integration tests. This will prevent collisions when the tests are running simultaneously against multiple commits/branches. Delete the CloudFormation stack at the end of the test run. It is possible that the stack will not be deleted if there is an error running the tests or the job is cancelled. These stacks would eventually have to be cleaned up manually, or we could automate the cleanup if this becomes burdensome.serverless.yml
. This doubled the overall execution length of the tests, which is already quite long. Also, we should not be testing the Serverless plugin in this manner for a few additional reasons:sa-east-1
(previouslyus-east-1
)Motivation
Right now, because the integration tests are not run on each commit, it is easy to break the tests (either by introducing an actual bug or simply failing to update the tests) and not know about it for a long time. In fact, the tests are broken as of right now. By running the tests on every commit, we will ensure that they pass.
Types of Changes
Check all that apply