Ex builtin archives #200
Open
Ex builtin archives #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e archives, update common/include/nbl/examples/common/BuiltinResourcesApplication.hpp and test on 09 example
…et created with NBL_REGISTER_SPIRV_SHADERS utility, update CSimpleDebugRenderer.hpp, change location of unified.hlsl
CMakeLists.txt
Outdated
| @@ -95,6 +95,9 @@ if(NBL_BUILD_EXAMPLES) | |||
| target_link_libraries(${T} PUBLIC ${NBL_EXAMPLES_API_TARGET}) | |||
| target_include_directories(${T} PUBLIC $<TARGET_PROPERTY:${NBL_EXAMPLES_API_TARGET},INCLUDE_DIRECTORIES>) | |||
| target_precompile_headers(${T} REUSE_FROM "${NBL_EXAMPLES_API_TARGET}") | |||
| LINK_BUILTIN_RESOURCES_TO_TARGET(${T} NblExtExamplesAPIBuiltinsSource) | |||
| LINK_BUILTIN_RESOURCES_TO_TARGET(${T} NblExtExamplesAPIBuiltinsInclude) | |||
| LINK_BUILTIN_RESOURCES_TO_TARGET(${T} NblExtExamplesAPIBuiltinsSPIRV) | |||
There was a problem hiding this comment.
why SPIR-V, could be anything in the build dir really
Comment on lines
+14
to
+23
| #if __has_include("nbl/this_example/builtin/CArchive.h") | ||
| #include "nbl/this_example/builtin/CArchive.h" | ||
| #endif | ||
| // TODO: (**) there should be also 5th arch "nbl/this_example/builtin/build/spirv/CArchive.h" | ||
| /* | ||
| #if __has_include("nbl/this_example/builtin/build/spirv/CArchive.h") | ||
| #include "nbl/this_example/builtin/build/spirv/CArchive.h" | ||
| #endif | ||
| */ | ||
| //! this ain't meant to be the same as this_example ordinary archive |
There was a problem hiding this comment.
I think you need 3 (include,src,build) to keep symmetry with rest, then
… seems NSC cannot find boost headers (like something is off with mounting the boost directory)
…Examples-and-Tests into exBuiltinArchives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.