[SDK-548] Improve stability of tests for Java SDK #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victoriaxu098
changed the title
com.emc.object.s3.S3EncryptionClientBasicTest > testExtendObjectRetentionPeriod FAILED
shy950521
approved these changes
Apr 20, 2021
dongyeh
changed the title
…sWithEncoding . Root causes: 1. results by metadata search "x-amz-meta-field-valid=='true'" has no order, putting condition x-amz-meta-index-field will get it fixed. 2. SDK is not able to store special character into UMD, not a decent test for special characters but fine with listing objects with encoding.
…ListVersionsPaging
victoriaxu098
changed the title
added 3 commits
April 25, 2021 12:11
dongyeh
approved these changes
Apr 27, 2021
| @@ -102,6 +102,7 @@ protected static S3Config s3ConfigFromProperties() throws Exception { | |||
| String secretKey = TestConfig.getPropertyNotEmpty(props, TestProperties.S3_SECRET_KEY); | |||
| URI endpoint = new URI(TestConfig.getPropertyNotEmpty(props, TestProperties.S3_ENDPOINT)); | |||
| boolean enableVhost = Boolean.parseBoolean(props.getProperty(TestProperties.ENABLE_VHOST)); | |||
| boolean isSmartClient = Boolean.parseBoolean(props.getProperty(TestProperties.IS_SMART_CLIENT)); | |||
There was a problem hiding this comment.
Should be ENABLE_SMART_CLIENT?
There was a problem hiding this comment.
Have changed the property name to ENABLE_SMART_CLIENT
| @@ -15,5 +15,8 @@ s3.endpoint=http[s]://<ecshost>[:9020|:9021] | |||
| ## Uncomment to enable vhost-style requests (including the namespace) | |||
| #enableVhost=true | |||
|
|
|||
| ## Uncomment to disable smart client | |||
| #isSmartClient=false | |||
There was a problem hiding this comment.
By default it's commented, uncommenting it will disable smart client, so default is false.
victoriaxu098
changed the title
xiaoxin-ren
reviewed
Apr 29, 2021
xiaoxin-ren
requested changes
Apr 29, 2021
added 2 commits
May 7, 2021 09:58
…nt disabled 2. update smart client version to 2.3.1
xiaoxin-ren
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.