adjustments for some refactoring done in other branches #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
twincitiesguy
commented
Aug 2, 2021
twincitiesguy
commented
- Updated WriteTruncationTest to use slf4j (other test classes switched in a different branch)
- Refactored AbstractS3ClientTest.createS3Config as the only hook method for generating an S3Config instance - this also allows static reference to AbstractS3ClientTest.s3ConfigFromProperties
…ed in a different branch) * Refactored AbstractS3ClientTest.createS3Config as the only hook method for generating an S3Config instance - this also allows static reference to AbstractS3ClientTest.s3ConfigFromProperties
xiaoxin-ren
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.