tap_auditor: ensure lists of packages are in sorted order #19972
Conversation
botantony
force-pushed
the
tap_auditor
branch
5 times, most recently
from
a1c1a11 to
eead40c
Compare
| list_without_versions = if list_file == ".github/autobump.txt" | ||
| list | ||
| else | ||
| # Allow versioned packages not to follow the strict order |
There was a problem hiding this comment.
Because sometimes we want to arrange versioned in different order. Instead of ["package@1.10", "package@1.11", "package@1.9"] I'd prefer ["package@1.9", "package@1.10", "package@1.11"]
There was a problem hiding this comment.
It would be nice to enforce that ordering.
| list.map { |s| s.split("@", 2).first } | ||
| end | ||
|
|
||
| sorted = list_without_versions.each_cons(2).all? do |a, b| |
There was a problem hiding this comment.
There's no built-in method to check if an array is sorted so I had to implement it on my own, see similar question on StackOverflow
https://stackoverflow.com/questions/8015775/check-to-see-if-an-array-is-already-sorted
There was a problem hiding this comment.
Generally comparing the array and array.sort is an easy way to verify this.
| a <= b | ||
| end | ||
|
|
||
| sorted = true if list_file == "formula_renames" # Skip sort check for renames |
There was a problem hiding this comment.
fromula_renames audit works with values of the keys, not the keys themselves.
In JSON like
{
"amtk": "libgedit-amtk",
"annie": "lux",
"ark": "velero",
"arm": "nyx",
"asciigen": "glyph"
}it checks if array ["libgedit-amtk", "lux", "velero", "nyx", "glyph"] is sorted
There was a problem hiding this comment.
do we check both keys and values are sorted elsewhere?
There was a problem hiding this comment.
The check is performed only on values, keys are not checked at all
There was a problem hiding this comment.
Feels like it'd be desirable to sort both keys and values.
Signed-off-by: botantony <antonsm21@gmail.com>
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?It would be nice to check if lists of formulae/casks in files (f.e.
autobump.txtorformula_renames) are in sorted order