Skip to content

chore: removed RSA1_5 as default enc alg #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2022
Merged

chore: removed RSA1_5 as default enc alg #125

merged 2 commits into from
Jun 22, 2022

Conversation

peppelinux
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

Merging #125 (619f9ef) into main (d172218) will increase coverage by 0.17%.
The diff coverage is 97.43%.

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   77.26%   77.44%   +0.17%     
==========================================
  Files          41       42       +1     
  Lines        4324     4362      +38     
  Branches      836      842       +6     
==========================================
+ Hits         3341     3378      +37     
  Misses        718      718              
- Partials      265      266       +1     
Impacted Files Coverage Δ
src/cryptojwt/jwt.py 76.88% <ø> (ø)
src/cryptojwt/jwe/fernet.py 97.36% <97.36%> (ø)
src/cryptojwt/jws/jws.py 80.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec79b98...619f9ef. Read the comment docs.

@peppelinux peppelinux requested review from jschlyter and rohe June 21, 2022 07:04
jschlyter
jschlyter previously approved these changes Jun 21, 2022
Copy link
Collaborator

@jschlyter jschlyter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the commit should say what we replace it with?
Would it make sense to also move from CBC to GCM?

Copy link
Collaborator

@jschlyter jschlyter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, much better defaults. Are there any interoperability issues that we are aware of @rohe ?

@rohe
Copy link
Contributor

rohe commented Jun 22, 2022

Not that I know of.

@jschlyter jschlyter merged commit b5f389f into main Jun 22, 2022
@jschlyter jschlyter deleted the remove-rsa15 branch June 22, 2022 09:03
@jschlyter jschlyter restored the remove-rsa15 branch June 22, 2022 09:09
@jschlyter jschlyter deleted the remove-rsa15 branch November 25, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants