-
Notifications
You must be signed in to change notification settings - Fork 17
chore: removed RSA1_5 as default enc alg #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #125 +/- ##
==========================================
+ Coverage 77.26% 77.44% +0.17%
==========================================
Files 41 42 +1
Lines 4324 4362 +38
Branches 836 842 +6
==========================================
+ Hits 3341 3378 +37
Misses 718 718
- Partials 265 266 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the commit should say what we replace it with?
Would it make sense to also move from CBC to GCM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, much better defaults. Are there any interoperability issues that we are aware of @rohe ?
Not that I know of. |
No description provided.