Skip to content

Improve key_from_jwk_dict #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2019

Conversation

jschlyter
Copy link
Collaborator

  • bring back private parameter to key_from_jwk_dict (was present in earlier releases)
  • check for all required key parameters in key_from_jwk_dict
  • add test case for public rsa key
  • add test case for public/private ec key

check for all required key parameters in key_from_jwk_dict
add test case for public rsa key
add test case for public/private ec key
@codecov-io
Copy link

codecov-io commented Feb 18, 2019

Codecov Report

Merging #16 into master will decrease coverage by 0.07%.
The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   82.02%   81.94%   -0.08%     
==========================================
  Files          34       34              
  Lines        3216     3252      +36     
  Branches      610      618       +8     
==========================================
+ Hits         2638     2665      +27     
- Misses        366      371       +5     
- Partials      212      216       +4
Impacted Files Coverage Δ
src/cryptojwt/jwk/jwk.py 77.22% <73.68%> (-1.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddafa27...efc80ab. Read the comment docs.

@rohe rohe merged commit 4bfd491 into IdentityPython:master Feb 18, 2019
@jschlyter jschlyter deleted the key_from_jwk_dict_private branch October 15, 2019 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants