Skip to content

Refresh keybundle #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2020
Merged

Conversation

jschlyter
Copy link
Collaborator

  • set and honor If-Modified-Since on remote requests
  • re-read files automatically if changed (files checked every cache_time seconds)

@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #42 into master will decrease coverage by 0.29%.
The diff coverage is 53.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   77.84%   77.54%   -0.30%     
==========================================
  Files          38       38              
  Lines        3773     3804      +31     
  Branches      739      743       +4     
==========================================
+ Hits         2937     2950      +13     
- Misses        603      618      +15     
- Partials      233      236       +3     
Impacted Files Coverage Δ
src/cryptojwt/key_bundle.py 79.96% <53.65%> (-2.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85e7aec...351bf7e. Read the comment docs.

@rohe
Copy link
Contributor

rohe commented May 14, 2020

Hmm, have to work on the code coverage.

@rohe rohe merged commit fb77ad8 into IdentityPython:master May 14, 2020
@jschlyter jschlyter deleted the refresh_keybundle branch May 14, 2020 14:39
@jschlyter
Copy link
Collaborator Author

https://pypi.org/project/requests-mock/ is your friend

@jschlyter
Copy link
Collaborator Author

I'll fix better coverage...

@rohe
Copy link
Contributor

rohe commented May 14, 2020

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants