Skip to content

Allow support of SHA256 #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

pjsg
Copy link

@pjsg pjsg commented Feb 28, 2019

I think that this PR addresses the issue #136 -- but I'm having difficulty testing it in a real environment. It also might not be the right approach. However, it does appear to work in my test environment (I have a patched version of Mujina to test against).

This code is also rather specific to adding sha256 and not generic algorithm support.

@peppelinux
Copy link
Member

I made a PR here:
IdentityPython/pysaml2#597

it has been tested, hope to see a reply from pysaml2-dev team

@peppelinux
Copy link
Member

Hi @pjsg, I fixed this beahviour with a patch in pySAML2. This still needs to be merged there but I'm working with my pySAML2 fork and everything works great in production, with many entities like Shibboleth IdP and ADFS.

If you agree I think that this feature should be handled in pysaml2, SHA256 is nowadays supported by all the existing platforms so I configured it as default in pysaml2 (instead of the deprecable SHA1).

I close this for now but feel free to put your comments, we can reopen this whatever we want

@peppelinux peppelinux closed this Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants