Allow support of SHA256 #144
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made a PR here: it has been tested, hope to see a reply from pysaml2-dev team |
|
Hi @pjsg, I fixed this beahviour with a patch in pySAML2. This still needs to be merged there but I'm working with my pySAML2 fork and everything works great in production, with many entities like Shibboleth IdP and ADFS. If you agree I think that this feature should be handled in pysaml2, SHA256 is nowadays supported by all the existing platforms so I configured it as default in pysaml2 (instead of the deprecable SHA1). I close this for now but feel free to put your comments, we can reopen this whatever we want |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that this PR addresses the issue #136 -- but I'm having difficulty testing it in a real environment. It also might not be the right approach. However, it does appear to work in my test environment (I have a patched version of Mujina to test against).
This code is also rather specific to adding sha256 and not generic algorithm support.