Skip to content

fix(combo): align case sensitive icon styling with WC #15902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2025

Conversation

adrianptrv
Copy link

Closes #15852

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@@ -177,6 +173,7 @@
igx-icon {
// Important is needed since the .igx-icon--inactive has !important
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of !important use
--igx-icon-disabled-color: var(--ig-gray-600);

@desig9stein desig9stein added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 5, 2025
desig9stein
desig9stein previously approved these changes Jun 5, 2025
@ChronosSF ChronosSF changed the base branch from master to 20.0.x June 9, 2025 11:55
@ChronosSF ChronosSF dismissed desig9stein’s stale review June 9, 2025 11:55

The base branch was changed.

@simeonoff simeonoff merged commit c7a077a into 20.0.x Jun 12, 2025
3 checks passed
@simeonoff simeonoff deleted the apetrov/case-sensitive-icon-colors branch June 12, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
combo styling version: 20.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Combo]: "Case sensitive icon" style discrepancies
4 participants