Skip to content

feat(igx-vhelper): create and use css var for scrollbar size #15918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 12, 2025

Conversation

didimmova
Copy link
Contributor

Closes #15777
Closes #15776

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@didimmova didimmova requested a review from simeonoff June 9, 2025 08:15
@desig9stein desig9stein added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jun 9, 2025
@didimmova didimmova changed the base branch from master to 20.0.x June 11, 2025 07:39
Comment on lines 98 to 101
#{$scope} {
--igx-vhelper-scrollbar-size: 1rem;
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Register this as a custom property using the @property syntax as done for --_progress-integer. You can do this in the core.scss file instead of here.

@simeonoff simeonoff self-requested a review June 11, 2025 14:37
@simeonoff simeonoff merged commit 6156bce into 20.0.x Jun 12, 2025
2 of 6 checks passed
@simeonoff simeonoff deleted the didimmova/vhelper-scrollbar-master branch June 12, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scrollbar version: 20.0.x virtualization ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vhelper] - Change vhelper inline styles to a global css variables [Combo] - Combo dropdown items go under the virtual scrollbar
3 participants