Skip to content

IgxCombo test refactoring #6598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Feb 28, 2020
Merged

IgxCombo test refactoring #6598

merged 25 commits into from
Feb 28, 2020

Conversation

PlamenaMiteva
Copy link
Contributor

@PlamenaMiteva PlamenaMiteva commented Feb 4, 2020 •
edited by Lipata
Loading

Closes #6450

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@PlamenaMiteva
test(combo): combo tests refactoring#6450
3424080
@PlamenaMiteva
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
748de55 
…into PMiteva/fix-combo-tests

# Conflicts:
#	projects/igniteui-angular/src/lib/combo/combo.component.spec.ts
@PlamenaMiteva PlamenaMiteva requested a review from Lipata February 4, 2020 09:52
nrobakova
nrobakova suggested changes Feb 14, 2020
View reviewed changes
@PlamenaMiteva PlamenaMiteva force-pushed the PMiteva/fix-combo-tests branch from fb783ea to f7ff8d0 Compare February 19, 2020 11:22
@Lipata Lipata requested a review from nrobakova February 19, 2020 11:51
nrobakova
nrobakova suggested changes Feb 27, 2020
View reviewed changes
@nrobakova nrobakova added the ✅ status: verified Applies to PRs that have passed manual verification label Feb 27, 2020
@kdinev kdinev merged commit 3f32096 into master Feb 28, 2020
@kdinev kdinev deleted the PMiteva/fix-combo-tests branch February 28, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrobakova nrobakova nrobakova approved these changes

@Lipata Lipata Awaiting requested review from Lipata

@igdmdimitrov igdmdimitrov Awaiting requested review from igdmdimitrov

@skrustev skrustev Awaiting requested review from skrustev

Assignees
No one assigned
Labels
combo 🧪 ci: tests version: 9.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests Refactoring: igxCombo
4 participants
@PlamenaMiteva @nrobakova @kdinev @Lipata