Add visual validity state and required asterisk for date and time pickers #6722
+586
−217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wnvko
added
📅 date-picker
🛠️ status: in-development
wnvko
added
❌ status: awaiting-test
damyanpetev
changed the title
damyanpetev
reviewed
Feb 18, 2020
projects/igniteui-angular/src/lib/date-picker/date-picker.component.html
Show resolved
Hide resolved
wnvko
added a commit
that referenced
this pull request
Feb 19, 2020
If we drop down the calendar when input has no value, onBlur gets called but we do not call onTouchCallback which is correct. However if after we click outside the input the model is never validated. This is why we should validate model, in this case, and in onClosed event.
If we drop down the calendar when input has no value, onBlur gets called but we do not call onTouchCallback which is correct. However if after we click outside the input the model is never validated. This is why we should validate model, in this case, and in onClosing event.
wnvko
force-pushed
the
mvenkov/handle-required-in-date-time-pickers
branch
from
f001cf6 to
e21d466
Compare
…dle-required-in-date-time-pickers
Also force setting of this.validy to pass trouth setter always
…dle-required-in-date-time-pickers
…onent.ts Co-Authored-By: Damyan Petev <damyanpetev@users.noreply.github.com>
…//github.com/IgniteUI/igniteui-angular into mvenkov/handle-required-in-date-time-pickers
…//github.com/IgniteUI/igniteui-angular into mvenkov/handle-required-in-date-time-pickers
damyanpetev
reviewed
Mar 2, 2020
|
|
||
| UIInteractions.clickElement(datePickerOnBlurComponent.getEditElement(), HorizontalAlignment.Center, VerticalAlignment.Middle); | ||
| UIInteractions.clickElement(datePickerOnBlurComponent.getEditElement()); |
There was a problem hiding this comment.
That should still be a trigger handler call for focus instead
wnvko
commented
Mar 2, 2020
projects/igniteui-angular/src/lib/directives/input/input.directive.ts
Outdated
Show resolved
Hide resolved
…//github.com/IgniteUI/igniteui-angular into mvenkov/handle-required-in-date-time-pickers
…dle-required-in-date-time-pickers # Conflicts: # projects/igniteui-angular/src/lib/date-picker/date-picker.component.spec.ts # projects/igniteui-angular/src/lib/time-picker/time-picker.component.html
damyanpetev
approved these changes
Mar 5, 2020
jackofdiamond5
added
💥 status: in-test
Lipata
approved these changes
Mar 6, 2020
Lipata
pushed a commit
that referenced
this pull request
Mar 6, 2020
Lipata
pushed a commit
that referenced
this pull request
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the code to correctly handle state validity of the components
Closes #6471
Closes #6846
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes