Skip to content

Merge changes cause I forgot to switch branch and this is easier #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/commons/application/ApplicationTypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,8 @@ export const defaultWorkspaceManager: WorkspaceManagerState = {
},
currentSubmission: undefined,
currentQuestion: undefined,
hasUnsavedChanges: false
hasUnsavedChanges: false,
requestCounter: 0
},
playground: {
...createDefaultWorkspace('playground'),
Expand Down
6 changes: 6 additions & 0 deletions src/commons/workspace/WorkspaceActions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ import {
UPDATE_GRADING_COLUMN_VISIBILITY,
UPDATE_HAS_UNSAVED_CHANGES,
UPDATE_REPL_VALUE,
UPDATE_REQUEST_COUNTER,
UPDATE_STEPSTOTAL,
UPDATE_SUBLANGUAGE,
UPDATE_SUBMISSIONS_TABLE_FILTERS,
Expand Down Expand Up @@ -395,6 +396,11 @@ export const setIsEditorReadonly = createAction(
})
);

export const updateRequestCounter = createAction(
UPDATE_REQUEST_COUNTER,
(requestCount: number) => ({ payload: { requestCount } })
);

export const updateSubmissionsTableFilters = createAction(
UPDATE_SUBMISSIONS_TABLE_FILTERS,
(filters: SubmissionsTableFilters) => ({ payload: { filters } })
Expand Down
9 changes: 9 additions & 0 deletions src/commons/workspace/WorkspaceReducer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ import {
UPDATE_GRADING_COLUMN_VISIBILITY,
UPDATE_HAS_UNSAVED_CHANGES,
UPDATE_REPL_VALUE,
UPDATE_REQUEST_COUNTER,
UPDATE_STEPSTOTAL,
UPDATE_SUBLANGUAGE,
UPDATE_SUBMISSIONS_TABLE_FILTERS,
Expand Down Expand Up @@ -658,6 +659,14 @@ const oldWorkspaceReducer: Reducer<WorkspaceManagerState> = (
currentQuestion: action.payload.questionId
}
};
case UPDATE_REQUEST_COUNTER:
return {
...state,
grading: {
...state.grading,
requestCounter: action.payload.requestCount
}
};
case SET_FOLDER_MODE:
return {
...state,
Expand Down
2 changes: 2 additions & 0 deletions src/commons/workspace/WorkspaceTypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export const TOGGLE_EDITOR_AUTORUN = 'TOGGLE_EDITOR_AUTORUN';
export const TOGGLE_USING_SUBST = 'TOGGLE_USING_SUBST';
export const TOGGLE_USING_CSE = 'TOGGLE_USING_CSE';
export const TOGGLE_UPDATE_CSE = 'TOGGLE_UPDATE_CSE';
export const UPDATE_REQUEST_COUNTER = 'UPDATE_REQUEST_COUNTER';
export const UPDATE_SUBMISSIONS_TABLE_FILTERS = 'UPDATE_SUBMISSIONS_TABLE_FILTERS';
export const UPDATE_GRADING_COLUMN_VISIBILITY = 'UPDATE_GRADING_COLUMN_VISIBILITY';
export const UPDATE_CURRENT_ASSESSMENT_ID = 'UPDATE_CURRENT_ASSESSMENT_ID';
Expand Down Expand Up @@ -82,6 +83,7 @@ type GradingWorkspaceAttr = {
readonly currentSubmission?: number;
readonly currentQuestion?: number;
readonly hasUnsavedChanges: boolean;
readonly requestCounter: number;
};
type GradingWorkspaceState = GradingWorkspaceAttr & WorkspaceState;

Expand Down
13 changes: 11 additions & 2 deletions src/pages/academy/grading/Grading.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@ import '@tremor/react/dist/esm/tremor.css';
import { Icon as BpIcon, NonIdealState, Position, Spinner, SpinnerSize } from '@blueprintjs/core';
import { IconNames } from '@blueprintjs/icons';
import { Button, Card, Flex, Text, Title } from '@tremor/react';
import React, { useCallback, useState } from 'react';
import React, { useCallback, useEffect, useState } from 'react';
import { useDispatch } from 'react-redux';
import { Navigate, useParams } from 'react-router';
import { fetchGradingOverviews } from 'src/commons/application/actions/SessionActions';
import { Role } from 'src/commons/application/ApplicationTypes';
import SimpleDropdown from 'src/commons/SimpleDropdown';
import { useSession } from 'src/commons/utils/Hooks';
import { useSession, useTypedSelector } from 'src/commons/utils/Hooks';
import { updateRequestCounter } from 'src/commons/workspace/WorkspaceActions';
import { numberRegExp } from 'src/features/academy/AcademyTypes';
import {
exportGradingCSV,
Expand Down Expand Up @@ -50,8 +51,12 @@ const Grading: React.FC = () => {
const [showAllSubmissions, setShowAllSubmissions] = useState(false);

const dispatch = useDispatch();
const requestCounter = useTypedSelector(state => state.workspaces.grading.requestCounter);

const updateGradingOverviewsCallback = useCallback(
(page: number, filterParams: Object) => {
console.log("+1 parent");
dispatch(updateRequestCounter(requestCounter + 1));
dispatch(
fetchGradingOverviews(
showAllGroups,
Expand All @@ -64,6 +69,10 @@ const Grading: React.FC = () => {
[dispatch, showAllGroups, showAllSubmissions, pageSize]
);

useEffect(() => {
dispatch(updateRequestCounter(Math.max(0, requestCounter - 1)));
}, [gradingOverviews]);

// If submissionId or questionId is defined but not numeric, redirect back to the Grading overviews page
if (
(params.submissionId && !params.submissionId?.match(numberRegExp)) ||
Expand Down
Loading