Skip to content

Add implementation of unique functions from Python array API #2320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 19, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Feb 17, 2025

The PR implements dpnp.unique_all, dpnp.unique_counts, dpnp.unique_inverse and dpnp.unique_values which are required to be compliant with Python array API.
All of them are leveraging on dpnp.unique call but with different set of input flags passed through.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

github-actions bot commented Feb 17, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy force-pushed the impl-unique-functions branch from 47ac701 to bfcec3e Compare February 17, 2025 17:51
Copy link
Contributor

github-actions bot commented Feb 17, 2025

Array API standard conformance tests for dpnp=0.17.0dev6=py312he4f9c94_25 ran successfully.
Passed: 1004
Failed: 0
Skipped: 10

Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 71.763% (+0.02%) from 71.742%
when pulling 78d2ce9 on impl-unique-functions
into b09533e on master.

@antonwolfy antonwolfy merged commit 37e9176 into master Feb 19, 2025
64 of 66 checks passed
@antonwolfy antonwolfy deleted the impl-unique-functions branch February 19, 2025 09:29
github-actions bot added a commit that referenced this pull request Feb 19, 2025
The PR implements `dpnp.unique_all`, `dpnp.unique_counts`,
`dpnp.unique_inverse` and `dpnp.unique_values` which are required to be
compliant with Python array API.
All of them are leveraging on `dpnp.unique` call but with different set
of input flags passed through. 37e9176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants