Skip to content

Resolve failures in tests while running with numpy 2.0 #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Feb 19, 2025

The PR proposes to resolve faults in dpnp tests when running towards numpy 2.0.
The affected tests assume numpy fixes released in 2.1 version, so the tests logic has to be updated to align with expected numpy behavior depending on the version used.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

github-actions bot commented Feb 19, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 71.763%. remained the same
when pulling 6d64431 on update-tests-dep-on-numpy-ver
into 37e9176 on master.

Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @antonwolfy
Looks good

Copy link
Contributor

Array API standard conformance tests for dpnp=0.17.0dev6=py312he4f9c94_21 ran successfully.
Passed: 1004
Failed: 0
Skipped: 10

@antonwolfy antonwolfy merged commit f56a43f into master Feb 19, 2025
65 of 67 checks passed
@antonwolfy antonwolfy deleted the update-tests-dep-on-numpy-ver branch February 19, 2025 12:25
github-actions bot added a commit that referenced this pull request Feb 19, 2025
The PR proposes to resolve faults in dpnp tests when running towards
numpy 2.0.
The affected tests assume numpy fixes released in 2.1 version, so the
tests logic has to be updated to align with expected numpy behavior
depending on the version used. f56a43f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants