Change runOnIdle to execute on the UI thread, and to not waitForIdle afterward
#1601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-sasha
force-pushed
the
m-sasha/report-idle-with-delayed-launched-effect
branch
3 times, most recently
from
4cfc512 to
c973fff
Compare
m-sasha
force-pushed
the
m-sasha/fix-run-on-idle
branch
from
3cffe4e to
12e5e54
Compare
m-sasha
force-pushed
the
m-sasha/report-idle-with-delayed-launched-effect
branch
from
c973fff to
28c3cda
Compare
Base automatically changed from
m-sasha/report-idle-with-delayed-launched-effect
to
jb-main
October 1, 2024 08:43
m-sasha
force-pushed
the
m-sasha/fix-run-on-idle
branch
from
12e5e54 to
92c71b9
Compare
eymar
reviewed
Oct 1, 2024
compose/ui/ui-test-junit4/src/desktopTest/kotlin/androidx/compose/ui/test/TestBasicsTest.kt
Show resolved
Hide resolved
eymar
approved these changes
Oct 1, 2024
Updated the release notes. |
igordmn
pushed a commit
that referenced
this pull request
Feb 25, 2025
…le` afterward (#1601) # Conflicts: # compose/ui/ui-test/src/skikoTest/kotlin/androidx/compose/ui/test/TestBasicsTest.kt # navigation/navigation-compose/src/commonTest/kotlin/androidx/navigation/compose/NavHostTest.kt
zamulla
added a commit
to JetBrains/kotlin-multiplatform-dev-docs
that referenced
this pull request
Mar 21, 2025
Describing breaking changes introduced here: JetBrains/compose-multiplatform-core#1601
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current implementation of
runOnIdledoes two things differently from Android:waitForIdlecall afteractionhas returned.This PR changes that. aligning the behavior with Android.
Testing
Describe how you tested your changes. If possible and needed:
Release Notes
Breaking Changes - Tests
runOnIdlewill now executeactionon the UI thread aligning the behavior with Android.runOnIdlewill no longer callwaitForIdleafter executing the action aligning the behavior with Android.