Fix missed implementation for DrawerPredictiveBackHandler
#1763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
reviewed
Jan 6, 2025
...ose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationDrawer.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
force-pushed
the
ivan.matkov/common-nav-drawer
branch
from
76b927d to
8d67a83
Compare
MatkovIvan
changed the title
DrawerPredictiveBackHandlerDrawerPredictiveBackHandler
ASalavei
approved these changes
Jan 6, 2025
igordmn
approved these changes
Jan 6, 2025
igordmn
pushed a commit
that referenced
this pull request
Feb 25, 2025
Since `PredictiveBackHandler` were previously commonized (without actual implementation yet), it's no longer necessary to wrap usages of it into expect/actual. It fixes missing implementation of `DrawerPredictiveBackHandler` on non-Android platforms. Fixes https://youtrack.jetbrains.com/issue/CMP-1301 and https://youtrack.jetbrains.com/issue/CMP-7309 ## Release Notes ### Fixes - Multiple Platforms - Fix missing implementation on non-Android platforms for `ModalDrawerSheet` overload with `DrawerState` argument
igordmn
pushed a commit
that referenced
this pull request
Feb 25, 2025
Since `PredictiveBackHandler` were previously commonized (without actual implementation yet), it's no longer necessary to wrap usages of it into expect/actual. It fixes missing implementation of `DrawerPredictiveBackHandler` on non-Android platforms. Fixes https://youtrack.jetbrains.com/issue/CMP-1301 and https://youtrack.jetbrains.com/issue/CMP-7309 ## Release Notes ### Fixes - Multiple Platforms - Fix missing implementation on non-Android platforms for `ModalDrawerSheet` overload with `DrawerState` argument
igordmn
pushed a commit
that referenced
this pull request
Feb 25, 2025
Since `PredictiveBackHandler` were previously commonized (without actual implementation yet), it's no longer necessary to wrap usages of it into expect/actual. It fixes missing implementation of `DrawerPredictiveBackHandler` on non-Android platforms. Fixes https://youtrack.jetbrains.com/issue/CMP-1301 and https://youtrack.jetbrains.com/issue/CMP-7309 ## Release Notes ### Fixes - Multiple Platforms - Fix missing implementation on non-Android platforms for `ModalDrawerSheet` overload with `DrawerState` argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
PredictiveBackHandlerwere previously commonized (without actual implementation yet), it's no longer necessary to wrap usages of it into expect/actual. It fixes missing implementation ofDrawerPredictiveBackHandleron non-Android platforms.Fixes https://youtrack.jetbrains.com/issue/CMP-1301 and https://youtrack.jetbrains.com/issue/CMP-7309
Release Notes
Fixes - Multiple Platforms
ModalDrawerSheetoverload withDrawerStateargument