Skip to content

Match Composable actual uikit API with expected one #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

Match Composable actual uikit API with expected one #1919

merged 1 commit into from
Mar 13, 2025

Conversation

ASalavei
Copy link

@ASalavei ASalavei commented Mar 12, 2025 •
edited
Loading

Add Composable annotation to the WindowInsets.Companion.waterfall getter to match the expected API

Release Notes

Breaking Changes - iOS

  • Add Composable annotation to the WindowInsets.Companion.waterfall getter to match the expected API

@ASalavei ASalavei requested review from MatkovIvan and igordmn March 12, 2025 22:08
MatkovIvan
MatkovIvan approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to do it, but it's a possible binary compatibility problem, so please write proper release notes

@ASalavei ASalavei merged commit 504e965 into jb-main Mar 13, 2025
9 checks passed
@ASalavei ASalavei deleted the andrei.salavei/match-api-composable branch March 13, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatkovIvan MatkovIvan MatkovIvan approved these changes

@igordmn igordmn igordmn approved these changes

Assignees
No one assigned
Labels
changes in API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ASalavei @MatkovIvan @igordmn