Skip to content

[Cherry-pick] TextFieldKeyEventHandler for iOS #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

mazunin-v-jb
Copy link

Implemented TextFieldKeyEventHandler for iOS target to avoid sending multiple EditCommands via using hardware keyboard on device / simulator in BTF2

Fixes: https://youtrack.jetbrains.com/issue/CMP-7893/Shiftarrow-up-does-not-select-on-BTF2

Testing

Manual, use a hardware keyboard and try to select the text with Shift + Arrows, and just use arrows for navigation

Release Notes

Fixes - iOS

Fixed incorrect selection and navigation by arrow keys from a hardware keyboard in BasicTextField(TextFieldState)

Implemented TextFieldKeyEventHandler for iOS target to avoid sending
multiple EditCommands via using hardware keyboard on device / simulator
in BTF2

Fixes:
https://youtrack.jetbrains.com/issue/CMP-7893/Shiftarrow-up-does-not-select-on-BTF2

## Testing
Manual, use a hardware keyboard and try to select the text with Shift +
Arrows, and just use arrows for navigation

## Release Notes
### Fixes - iOS
Fixed incorrect selection and navigation by arrow keys from a hardware
keyboard in `BasicTextField(TextFieldState)`
@mazunin-v-jb mazunin-v-jb requested a review from Kpotko April 16, 2025 11:35
@mazunin-v-jb mazunin-v-jb changed the title TextFieldKeyEventHandler for iOS (#2002) [Cherry-pick] TextFieldKeyEventHandler for iOS Apr 16, 2025
@Kpotko Kpotko merged commit e7d6f54 into release/1.8 Apr 16, 2025
10 checks passed
@Kpotko Kpotko deleted the v.mazunin/cherry-pick-2002 branch April 16, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants