Add API for iOS IME Options #2108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svastven
commented
May 12, 2025
MatkovIvan
requested changes
May 13, 2025
...e/ui/ui-text/src/uikitMain/kotlin/androidx/compose/ui/text/input/PlatformImeOptions.uikit.kt
Outdated
Show resolved
Hide resolved
svastven
force-pushed
the
svastven/textfield-ime-api
branch
from
f6df067 to
e7c2b0b
Compare
compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/ImeOptions.kt
Outdated
Show resolved
Hide resolved
svastven
force-pushed
the
svastven/textfield-ime-api
branch
2 times, most recently
from
d0ebd82 to
0eb23ac
Compare
MatkovIvan
reviewed
May 15, 2025
...i-text/src/uikitMain/kotlin/androidx/compose/ui/text/input/PlatformImeOptions.skiko.uikit.kt
Outdated
Show resolved
Hide resolved
...e/ui/ui-text/src/uikitMain/kotlin/androidx/compose/ui/text/input/PlatformImeOptions.uikit.kt
Outdated
Show resolved
Hide resolved
...i-text/src/uikitMain/kotlin/androidx/compose/ui/text/input/PlatformImeOptions.skiko.uikit.kt
Outdated
Show resolved
Hide resolved
...i-text/src/uikitMain/kotlin/androidx/compose/ui/text/input/PlatformImeOptions.skiko.uikit.kt
Outdated
Show resolved
Hide resolved
svastven
force-pushed
the
svastven/textfield-ime-api
branch
from
cecf88b to
0eb23ac
Compare
MatkovIvan
reviewed
May 15, 2025
mazunin-v-jb
approved these changes
May 18, 2025
MatkovIvan
approved these changes
May 19, 2025
| @@ -1380,7 +1380,7 @@ public final class androidx/compose/ui/text/input/PasswordVisualTransformation : | |||
| public fun hashCode ()I | |||
| } | |||
|
|
|||
| public final class androidx/compose/ui/text/input/PlatformImeOptions { | |||
| public class androidx/compose/ui/text/input/PlatformImeOptions { | |||
There was a problem hiding this comment.
cc @igordmn for awareness: changing actual skiko/non-android variant of an empty (not yet adopted) class to open.
There was a problem hiding this comment.
I would prefer adding uikit-only open variant of the PlatformImeOptions, keeping final for all other platforms.
There was a problem hiding this comment.
It's not compilation target specific. It's about how non-android variants handle that, so I see no reason to introduce the diff here.
Keep only skiko actual variant was an explicit ask from me above
ASalavei
approved these changes
May 20, 2025
svastven
force-pushed
the
svastven/textfield-ime-api
branch
2 times, most recently
from
bd7b1a3 to
a7270dc
Compare
svastven
force-pushed
the
svastven/textfield-ime-api
branch
from
a7270dc to
db3e5e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces iOS-specific IME options support for text input components. This enables users to access and configure native UIKit text input traits from Compose code.
Fixes - https://youtrack.jetbrains.com/issue/CMP-7882
Testing
iOS Platform IME Options section was added to the demo application into the iOS-specific features section
This should be tested by QA
Release Notes
Features - iOS
PlatformImeOptions