Fix InputMethodSession.getTextLocation #2118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-sasha
force-pushed
the
m-sasha/fix-InputMethodSession-getTextLocation-size
branch
from
d615503 to
bb3f1d1
Compare
igordmn
approved these changes
May 14, 2025
Kpotko
added a commit
that referenced
this pull request
Jun 10, 2025
… to density too (#2158) **This is a cherry-pick of #2118 into `release/1.8`.** The `focusRect` size needs to be scaled according to the density, too. Fixes https://youtrack.jetbrains.com/issue/CMP-8176/Input-Method-toolbar-too-far-from-text ## Testing Tested manually with ``` TextField( state = rememberTextFieldState(""), textStyle = LocalTextStyle.current.copy(fontSize = 64.sp), ) ``` This could be tested by QA ## Release Notes ### Fixes - Desktop - Fix the positioning of the IME popup being too far away from the text, on screens with density greater than 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
focusRectsize needs to be scaled according to the density, too.Fixes https://youtrack.jetbrains.com/issue/CMP-8176/Input-Method-toolbar-too-far-from-text
Testing
Tested manually with
This could be tested by QA
Release Notes
Fixes - Desktop