Skip to content

Update index.html of page titled "loading data" #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update index.html of page titled "loading data" #43

wants to merge 1 commit into from

Conversation

ven-k
Copy link
Contributor

@ven-k ven-k commented Mar 17, 2020

Screenshot (25)_LI
It leads to 404 as the link is "MLJTutorials/data".
This commit fixes it by adding "MLJTutorials/data/dataframe" in "MLJTutorials/__site/data/loading/index.html" file.

@tlienart
Copy link
Collaborator

tlienart commented Mar 17, 2020

Thanks a lot for this! however the file that should be modified (with the same fix) is this one: https://github.com/alan-turing-institute/MLJTutorials/blob/master/_literate/D0-loading.jl which is the source literate file for the generation; the HTML gets overwritten and so should not be modified.

In short: if you don't mind, please adjust your change to the file mentioned above; thanks!\
https://github.com/alan-turing-institute/MLJTutorials/blob/fcf7d2d86ddfa6033686583075e0ea0af418e153/_literate/D0-loading.jl#L24

@ven-k ven-k mentioned this pull request Mar 17, 2020
@ven-k
Copy link
Contributor Author

ven-k commented Mar 17, 2020

O Sorry for that.
I've opened #44 to change the tutorial link in the D0-loading.jl

@ven-k ven-k closed this Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants