-
Notifications
You must be signed in to change notification settings - Fork 97
opt-in for scatter operation in nvfuser #2183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Cool to see NVFuser expand the ops! What would be the circumstances in which one would opt in and not opt in? I can see why linear is a thing that is more tricky in terms of perf, but this seems to be a good option to always activate. I still think all options are more or less evil, but after #2057 , I'm more optimistic that this one could be temporary. |
Agree that these options are not good user experience. These are going to be a temporary thing. The reason I'm adding a flag is that we have concurrent work going on.
We'll see a couple similar ops added in the coming weeks (topk groupedgemm e.t.c.). We are not expecting any user to rely on these flags, since fallbacks don't necessarily provide any kernel perf gain. |
Looks like scatter related tests run fine. I'm not sure what the failure on stable torch 2.7 is about. I'll clean up the PR |
for more information, see https://pre-commit.ci
No description provided.