fix: enable parallel test execution with pytest-xdist in CI workflow #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deependujha
requested review from
Borda,
tchaton,
lantiga and
justusschock
as code owners
Codecov ReportAttention: Patch coverage is
❌ Your project check has failed because the head coverage (25%) is below the target coverage (99%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## main #620 +/- ##
=====================================
- Coverage 80% 25% -55%
=====================================
Files 43 43
Lines 6462 6464 +2
=====================================
- Hits 5155 1587 -3568
- Misses 1307 4877 +3570 🚀 New features to boost your workflow:
|
Borda
reviewed
Jun 12, 2025
Borda
reviewed
Jun 12, 2025
| run: coverage run --source litdata -m pytest tests -v --durations=100 | ||
| run: | | ||
| pip install pytest-xdist | ||
| coverage run --source litdata -m pytest tests -v --durations=100 -n auto |
There was a problem hiding this comment.
Suggested change
| coverage run --source litdata -m pytest tests -v --durations=100 -n auto | |
| coverage run --source litdata -m pytest tests -v --durations=100 -n 2 |
lets start just with 2 and we can bump the scale later
Borda
reviewed
Jun 12, 2025
Borda
reviewed
Jun 12, 2025
| @@ -556,6 +556,8 @@ def _terminate(self) -> None: | |||
| if self.remover and self.remover.is_alive(): | |||
| self.remover.join() | |||
|
|
|||
| sleep(5) # Give some buffer time for file creation/deletion | |||
There was a problem hiding this comment.
Rather have loop testing the it was created/deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
partial work on #612
follow-up work from #608 and #338
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃