fix _multiclass_stat_scores_update
in classification
#3078
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3068
This PR fixes an issue with the multiclass accuracy calculation when using
top_k > 1
withaverage="micro"
. The bug caused incorrect accuracy calculations in scenarios where predictions were provided as logits/probabilities and the correct class needed to be identified among the top-k predictions.The fix ensures that:
top_k > 1
, regardless of the averaging methodmulticlass_accuracy
to properly handle top-k with micro averagingThe PR includes test cases that demonstrate the issue and verify the fix works correctly. These tests show the alignment between manual calculations of top-k accuracy and the results from the metric implementation.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--3078.org.readthedocs.build/en/3078/
fixes #3068