Skip to content

Standard-conforming Format Descriptors with Fortran 2023 #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025

Conversation

okBrian
Copy link
Contributor

@okBrian okBrian commented May 19, 2025

Description

Fortran 2023 seems to strictly enforce standard-conforming format descriptors in format strings. Some of the print statements are missing commas between descriptors in format strings causing runtime errors when running gfortran (gcc 15) using the Fortran 2023 standard.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Scope

  • This PR comprises a set of related changes with a common goal

If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.

How Has This Been Tested?

  • Ran an example test case using gcc 15 locally.

Test Configuration:

  • What computers and compilers did you use to test this:
    Locally, GCC 15.1.1

Checklist

  • I ran ./mfc.sh format before committing my code
  • New and existing tests pass locally with my changes, including with GPU capability enabled (both NVIDIA hardware with NVHPC compilers and AMD hardware with CRAY compilers) and disabled
  • This PR does not introduce any repeated code (it follows the DRY principle)
  • I cannot think of a way to condense this code and reduce any introduced additional line count

If your code changes any code source files (anything in src/simulation)

To make sure the code is performing as expected on GPU devices, I have:

  • Checked that the code compiles using NVHPC compilers

@okBrian okBrian requested a review from a team as a code owner May 19, 2025 18:19
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.34%. Comparing base (f8e3912) to head (0f4c540).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #839   +/-   ##
=======================================
  Coverage   43.34%   43.34%           
=======================================
  Files          68       68           
  Lines       20127    20127           
  Branches     2400     2400           
=======================================
  Hits         8724     8724           
  Misses       9934     9934           
  Partials     1469     1469           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbryngelson sbryngelson merged commit da13f7f into MFlowCode:master May 21, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants