fix: Checkbox text ui #16130
fix: Checkbox text ui #16130
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16130 +/- ##
==========================================
- Coverage 70.73% 70.73% -0.01%
==========================================
Files 2570 2570
Lines 54858 54866 +8
Branches 8451 8454 +3
==========================================
+ Hits 38802 38807 +5
Misses 13587 13587
- Partials 2469 2472 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| const learnMoreCheckbox = getByText( | ||
| 'MetaMask can’t reset this password if you forget it', | ||
| const learnMoreCheckbox = getByTestId( | ||
| ImportFromSeedSelectorsIDs.CHECKBOX_TEXT_ID, |
There was a problem hiding this comment.
ChoosePasswordSelectorsIDs.I_UNDERSTAND_CHECKBOX_ID this seems to be the id attributed to the checkbox
So we are pressing the learn more link text and then expecting the confirm button to be pressable, I don't think we are really testing the component, since the confirm button shouldn't be pressable since we are pressing the learn more text and not the checkbox attached to it
There was a problem hiding this comment.
Since the button is being pressable even disabled, should we check if the button is disabled instead?
| /> | ||
| <TouchableOpacity |
There was a problem hiding this comment.
Please use ButtonLink instead
There was a problem hiding this comment.
Nice callout Brian, I missed it! Thanks
|
Description
UI issue on the create password of the Import SRP flow. The text learn more overlaps with the button
It should be a single Text component within the Text component should be used and style fix.Related issues
Fixes: Shoudl use a single Text component within that One more Text component for
Learn MoretextManual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist