Skip to content

fix: 13165 fix ledger blind sign error displayed not correctly #16200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dawnseeker8
Copy link
Contributor

@dawnseeker8 dawnseeker8 commented Jun 9, 2025

Description

This PR will fix issue #13165
This PR will upgrade @metamask/eth-ledger-keyring-bridge library to correctly handle the blind signing not enable error and user reject transaction error.

This PR will wait library upgrade PR merged and release first. MetaMask/accounts#294

Related issues

Fixes: #13165

Manual testing steps

  1. Install MM Mobile
  2. Recover from SRP
  3. Add hardware wallet (Ledger Stax)
  4. Add Ledger account from account list
  5. Launch MM Test dApp
  6. Connect with Ledger account
  7. Disable blind signing on Ledger device
  8. Sign typed data v4
  9. Verify error

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jun 9, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dawnseeker8 dawnseeker8 added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Run Smoke E2E Requires smoke E2E testing labels Jun 9, 2025
Copy link
Contributor

github-actions bot commented Jun 9, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4ca2ee1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c72faacb-13d2-495a-bdc2-48c96d73e8ac

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​@​metamask-previews/​eth-ledger-bridge-keyring@​11.0.3-87ad186751008497100

View full report

Copy link

sonarqubecloud bot commented Jun 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release. Run Smoke E2E Requires smoke E2E testing team-hardware-wallets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] When blind signing is disabled and user attempts to sign typed data v4 on Ledger device, invalid data received error displayed
2 participants